Comments (5)
Should the player create a node if none is passed in or always rely on having a node provided?
from paratii-mediaplayer.
My heart says it should create a node itself :-)
I'm just not sure about the start parameters... I'd say for now the easist fix is to keep the current code as the default if no node instance is provided to the contructor.
from paratii-mediaplayer.
Ah, if you've done this, can you also upgrade the reference in the portal package.json?
from paratii-mediaplayer.
Working on this now
from paratii-mediaplayer.
done
from paratii-mediaplayer.
Related Issues (20)
- Video title and sharing icon are paralysed/unresponsive HOT 1
- Design "stats" box HOT 4
- Implement stats box HOT 3
- Adapt volume icon and bar to our design HOT 9
- 🔧Implement video quality icon and function HOT 12
- Adapt full screen button to our design
- Implement user icon and wallet HOT 1
- 📺 Implement chromecast support HOT 2
- Make video title finish with [...] when too big HOT 1
- Media controls realignment on lower bar HOT 2
- Implement thumbnails when scrubbing HOT 1
- Implement thumbnail "video previews" when scrubbing HOT 5
- svg icons not appearing on windows X browser Y HOT 2
- Player violates Medium Do Not Track policy HOT 1
- Embedded player alignments are all messed up (small version) HOT 2
- Break video title line in the player ("..." at end) HOT 2
- Remove useless wallet icon from embedded player HOT 1
- Installation instructions incomplete
- Add keyboard shortcuts
- Close quality menu
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from paratii-mediaplayer.