Comments (5)
@jellegerbrandy semi-colons are required because of the prettier
formatting rules; right now those are overriding all standard
formatting rules (although non-formatting-related standard
rules should still be enforced).
My two cents is that we should let go of our code-formatting predispositions and just let prettier handle it, so we can worry about other things (encapsulated very well in this tweet)
https://twitter.com/jkkramer/status/889565403738976256
However, we can change this and enforce all standard
rules if we want. The downside would be that the prettier output alone would no longer pass our build process. Let me know what you think!
from paratii-portal.
Oh no, @bent0b0x , you have started a style war 😄
I vote for going back to have standard
as the basic: it is what we use for paratii-lib
and paratii-player
: it is better to be consistent, and we all have our IDE's configured for that (as well as our brains, or at least mine :-)
from paratii-portal.
Haha oh no!
Gotcha; I just found https://github.com/sheerun/prettier-standard, which looks like a prettier formatter that adheres to the standard
rules. I'll test this out today and look at swapping in for regular prettier
.
Or, just let me know if you think it is best to ditch an auto-formatter altogether. I personally really like using them but open to a different viewpoint.
from paratii-portal.
I am very much in favor of code standards, and I agree completely with the tweet you cited: that is more important to have a fixed style, but that the detaisl of that style are mostly abritrary : that is why I think we should not change them :-)
from paratii-portal.
Anyway, closing this as it seems to me perfect now :-)
from paratii-portal.
Related Issues (20)
- Need util to send PTI in integration tests HOT 3
- save the vote in local storage
- get real data for the dates (startchallenge, revealenddate, etc)
- implement the "clock" counter HOT 2
- link with paratii-js and db (we now use a mock) [SidebarTCR.js, TCRActions.js
- get the vote from local storage and call the reveal function
- set minDeposit in tcr contract to a decent value (5e18)
- Where to show the sidebar(UserNav) if max-width: 1440px HOT 3
- Rework Portal presentation to host AtB and focus on crypto HOT 6
- Implement categories on the landing page HOT 6
- [VOTE] Name for the portal web app - options (10 AUG) HOT 8
- List of content (~75 videos) for 6 categories on homepage HOT 4
- Change the header of the portal
- Change the copy of the login flow HOT 1
- Implement ''special search result page''
- Small profile fixes
- Change ''Episodes'' for ''Ep.'' on the main showcase of the Lab HOT 2
- Big files (>1gb) are breaking uploads HOT 1
- Add "cancel" feature to ongoing uploads, & "delete" to saved vids
- When there is no docker-compose.yml then there is this nice error message:
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from paratii-portal.