Comments (3)
I am really not sure about this. My belly tells me that the state should be managed in React/Redux and not in the browser history. Googling how you would do this in React Router also shows some really messy solutions. Even the StackOverflow question about whats the purpose of state objects in browser history doesnt give good examples.
I fear implementing such a mechanism that closely tied to the most basic building blocks of hookrouter invites for misuse through users.
from hookrouter.
Sure, it's not like I am using it often, but sometimes it happens. It can be useful for some optimization to basically pass data that are available on the current page so the next page can render faster because it knows something sooner, eg. form layout.
The main difference is that such state is tied to that exact navigation intent. If you go back in history or even refresh a browser, that state is there. If it would be solved on an app state level, it's fairly risky to run into some unexpected behavior.
from hookrouter.
Ah, I see now why you do not want to implement it. It clashes with API of #1. Makes sense that query params are probably more common than route state. I will try to figure if I can live without it or eventually fork the lib.
from hookrouter.
Related Issues (20)
- Native Typescript HOT 1
- Rendering Issue HOT 3
- BUG: query string is wiped out when navigate() is called with path only
- Direct navigation doesn't seem to work with GH Pages HOT 1
- Typescript error: index.d.ts file is missing HOT 8
- Support React 17 HOT 2
- Problem when using ListItem Material ui HOT 2
- React components using useRef hook break
- component rendering issue with react.strictmode HOT 1
- inside setLinkProps preventDefault sometimes does not stop navigation
- navigate() does not keep queryparameter even with fourth argument set to false HOT 3
- Import returning error "is not a module" when try to use hookrouter with CRA + typescript HOT 2
- TypeError: match is not a function
- Function to get the matched route outside of React (SSR)
- Navigate doesn't refresh useRoutes HOT 3
- Using Material UI Sidebar
- routing clears parent app state, how to maintain state while using this module?
- use hookrouter with react-redux
- Mark repo as archived if no longer updating 😄 HOT 3
- Application won't deploy on Heroku due to hookrouter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hookrouter.