Comments (4)
Nice catch! To be honest, I am not surprised because I had a suspicion about that code but at the time was busy fixing other things. I have cleaned up and updated Harmony/Harmony/ILCopying/MethodCopier.cs and fixed a few other edge cases. Those changes are not tested yet so feel free to let me know if things break.
from harmony.
I have commit changes that should clean up your case nicely. Would you be so kind to reevaluate your problem and let me know if this fixes it?
from harmony.
Yes, the original issue is fixed but a new issue using the same sample code from above has appeared.
Trace:
NullReferenceException: Object reference not set to an instance of an object
at Harmony.PatchTools.GetPatches (System.Type patchType, System.Reflection.MethodBase original, System.Reflection.MethodInfo& prefix, System.Reflection.MethodInfo& postfix, System.Reflection.MethodInfo& processors) [0x00000] in <filename unknown>:0
at Harmony.PatchProcessor.ProcessType () [0x00000] in <filename unknown>:0
at Harmony.PatchProcessor..ctor (Harmony.HarmonyInstance instance, System.Type type, Harmony.HarmonyMethod attributes) [0x00000] in <filename unknown>:0
at Harmony.HarmonyInstance.<PatchAll>b__0 (System.Type type) [0x00000] in <filename unknown>:0
at Harmony.CollectionExtensions.Do[Type] (IEnumerable`1 sequence, System.Action`1 action) [0x00000] in <filename unknown>:0
at Harmony.HarmonyInstance.PatchAll (System.Reflection.Assembly assembly) [0x00000] in <filename unknown>:0
at HarmonyKSPTesting.HarmonyBootstrapper+<Start>d__0.MoveNext () [0x00062] in d:\For New Computer\KSPCustomMods\Harmony-master\HarmonyKSPTesting\HarmonyBootstrapper.cs:29
at UnityEngine.SetupCoroutine.InvokeMoveNext (IEnumerator enumerator, IntPtr returnValueAddress) [0x00020] in C:\buildslave\unity\build\Runtime\Export\Coroutines.cs:17
It's misleading in that the error isn't actually within Harmony.PatchTools.GetPatches but in the caller:
PatchProcessor.ProcessType
If infix is null, NullReferenceException won't be thrown until attempting to set the parameter inside GetPatches
I worked around it by making an overload of GetPatches that doesn't require the infix parameter to be used if infix is null. Would you like me to create a new ticket for this issue?
from harmony.
Good catch. I prefer that you open a new one, if not just as a better reminder to myself.
from harmony.
Related Issues (20)
- Patch on .net 7&8 throw TypeLoadException while debugging HOT 18
- Harmony 3.0: Utility Epic
- Investigate Testing the NuGet Package Directly HOT 3
- Add a Release Pipeline
- Hook exception: System.Exception: Cannot get result from void method System.Void HOT 2
- How to patch method of base class? HOT 1
- When applying a patch fails, the replacement's IL is not printed to the debug log HOT 2
- System.Exception: Parameter "xx" not found in method HOT 10
- SymbolExtensions does not resolve overriden method HOT 3
- can lib work in arm64? HOT 2
- Companion project promotion: Harmony Tools HOT 3
- PatchFunctions.UpdateWrapper NotImplementedException on MacOS HOT 11
- How do i change valuetype HOT 1
- Harmony.Patch() is a bit slow. HOT 2
- 'CORINFO_METHOD_INFO' from assembly 'System.Text.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. HOT 4
- I try to hook DateTime.UtcNow but it throw exception HOT 5
- x86 platform makes patch fail
- return type only support void and bool? why doesn't string work HOT 1
- Could not load type 'CORINFO_METHOD_INFO' from assembly 'System.Text.Json, Version=8.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. HOT 1
- "ref" keyword not allowed for "__runOriginal" HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from harmony.