InvalidCastException inside MethodBodyReader.ReadOperand

[pardeike]

InvalidCastException inside MethodBodyReader.ReadOperand

[pardeike]

Nice catch! To be honest, I am not surprised because I had a suspicion about that code but at the time was busy fixing other things. I have cleaned up and updated Harmony/Harmony/ILCopying/MethodCopier.cs and fixed a few other edge cases. Those changes are not tested yet so feel free to let me know if things break.

[pardeike]

I have commit changes that should clean up your case nicely. Would you be so kind to reevaluate your problem and let me know if this fixes it?

[xEvilReeperx]

Yes, the original issue is fixed but a new issue using the same sample code from above has appeared.

Trace:

NullReferenceException: Object reference not set to an instance of an object
  at Harmony.PatchTools.GetPatches (System.Type patchType, System.Reflection.MethodBase original, System.Reflection.MethodInfo& prefix, System.Reflection.MethodInfo& postfix, System.Reflection.MethodInfo& processors) [0x00000] in <filename unknown>:0 
  at Harmony.PatchProcessor.ProcessType () [0x00000] in <filename unknown>:0 
  at Harmony.PatchProcessor..ctor (Harmony.HarmonyInstance instance, System.Type type, Harmony.HarmonyMethod attributes) [0x00000] in <filename unknown>:0 
  at Harmony.HarmonyInstance.<PatchAll>b__0 (System.Type type) [0x00000] in <filename unknown>:0 
  at Harmony.CollectionExtensions.Do[Type] (IEnumerable`1 sequence, System.Action`1 action) [0x00000] in <filename unknown>:0 
  at Harmony.HarmonyInstance.PatchAll (System.Reflection.Assembly assembly) [0x00000] in <filename unknown>:0 
  at HarmonyKSPTesting.HarmonyBootstrapper+<Start>d__0.MoveNext () [0x00062] in d:\For New Computer\KSPCustomMods\Harmony-master\HarmonyKSPTesting\HarmonyBootstrapper.cs:29 
  at UnityEngine.SetupCoroutine.InvokeMoveNext (IEnumerator enumerator, IntPtr returnValueAddress) [0x00020] in C:\buildslave\unity\build\Runtime\Export\Coroutines.cs:17 

It's misleading in that the error isn't actually within Harmony.PatchTools.GetPatches but in the caller:
PatchProcessor.ProcessType

If infix is null, NullReferenceException won't be thrown until attempting to set the parameter inside GetPatches

I worked around it by making an overload of GetPatches that doesn't require the infix parameter to be used if infix is null. Would you like me to create a new ticket for this issue?

[pardeike]

Good catch. I prefer that you open a new one, if not just as a better reminder to myself.