[RimWorld] Exception thrown when using __state in postfix patch

[pardeike]

[RimWorld] Exception thrown when using __state in postfix patch

[pardeike]

I think you are writing the result to a copy in your Prefix. A __state parameter makes only sense if you use it with the prefix ref or out. Also, I am pretty sure you cannot use __state from two patches to the same method. You need to make this a single patch with both: Prefix() and Postfix() at the same time.

Otherwise Harmony cannot allocate a local variable for you. How would it correlate the both __state to each other? What should happen if N patches have unique prefixes with __state and M postfixes want to use those __states. The solution I chose was to keep it locally within the same patch.

Just merge both classes into a single class, add the "out" modifier and you're done. I never split my classes into prefix/postfix if I need both anyway.

[pardeike]

namespace Xnope.Patches
{
    [HarmonyPatch(typeof(Faction), "GenerateNewLeader")]
    static class Faction_GenerateNewLeader_Patch
    {
        static void Prefix(Faction __instance, out string __state)
        {
            __state = "";
            if (__instance.leader != null)
                __state = __instance.leader.NameStringShort;
            else
                __state = "LNAME";
        }

        static void Postfix(Faction __instance, string __state)
        {

            if (__instance.IsDynamicallyNamed())
                ResolveFactionName(__instance, __state);
        }

        static void ResolveFactionName(Faction f, string oldLeaderName)
        {
            f.Name = f.Name.Replace(oldLeaderName, f.leader.NameStringShort);
        }
    }
}

[Pyr3z]

Thanks -- clears up so much! I separated the classes because a wiki page under HugsLib mentions that each patch needs to be in a separate class... suppose I misread it or it was untrue.
You're the man.