Comments (3)
I think you are writing the result to a copy in your Prefix. A __state
parameter makes only sense if you use it with the prefix ref
or out
. Also, I am pretty sure you cannot use __state
from two patches to the same method. You need to make this a single patch with both: Prefix() and Postfix() at the same time.
Otherwise Harmony cannot allocate a local variable for you. How would it correlate the both __state to each other? What should happen if N patches have unique prefixes with __state and M postfixes want to use those __states. The solution I chose was to keep it locally within the same patch.
Just merge both classes into a single class, add the "out" modifier and you're done. I never split my classes into prefix/postfix if I need both anyway.
from harmony.
namespace Xnope.Patches
{
[HarmonyPatch(typeof(Faction), "GenerateNewLeader")]
static class Faction_GenerateNewLeader_Patch
{
static void Prefix(Faction __instance, out string __state)
{
__state = "";
if (__instance.leader != null)
__state = __instance.leader.NameStringShort;
else
__state = "LNAME";
}
static void Postfix(Faction __instance, string __state)
{
if (__instance.IsDynamicallyNamed())
ResolveFactionName(__instance, __state);
}
static void ResolveFactionName(Faction f, string oldLeaderName)
{
f.Name = f.Name.Replace(oldLeaderName, f.leader.NameStringShort);
}
}
}
from harmony.
Thanks -- clears up so much! I separated the classes because a wiki page under HugsLib mentions that each patch needs to be in a separate class... suppose I misread it or it was untrue.
You're the man.
from harmony.
Related Issues (20)
- RtDynamicMethod get MetadataToken throws InvalidOperationException HOT 2
- Patch on .net 7&8 throw TypeLoadException while debugging HOT 18
- Harmony 3.0: Utility Epic
- Investigate Testing the NuGet Package Directly HOT 3
- Add a Release Pipeline
- Hook exception: System.Exception: Cannot get result from void method System.Void HOT 2
- How to patch method of base class? HOT 1
- When applying a patch fails, the replacement's IL is not printed to the debug log HOT 2
- System.Exception: Parameter "xx" not found in method HOT 10
- SymbolExtensions does not resolve overriden method HOT 3
- can lib work in arm64? HOT 2
- Companion project promotion: Harmony Tools HOT 3
- PatchFunctions.UpdateWrapper NotImplementedException on MacOS HOT 11
- How do i change valuetype HOT 1
- Harmony.Patch() is a bit slow. HOT 2
- 'CORINFO_METHOD_INFO' from assembly 'System.Text.Json, Version=7.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. HOT 4
- I try to hook DateTime.UtcNow but it throw exception HOT 5
- IL Compile Error when using PrefixFactory to provide a non-static Prefix method (Mono)
- x86 platform makes patch fail
- return type only support void and bool? why doesn't string work HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from harmony.