Patching instance methods

[pardeike]

Patching instance methods

[pardeike]

I would like to know in which environment you are executing Harmony. On mono, which is the main focus of this lib, a DynamicMethod is static but can emulate an instance method by choosing the correct attributes.

In case you are executing this on Core you might want to test again with the lastest commits. I just accepted a pull request that deals with that environment.

[Kittyfisto]

I'm running this code on Win10, using .NET 4.6.2 and I'm actually working with those changes you've merged earlier, including two little changes of my own to allow patching of static method under .NET 4.6.2, as detailed here.

[0x0ade]

From what I understand, the only required criterion to emulate an instance method properly is using the first argument (technically 0th argument) passed as this, very similar to how extension methods work. I haven't seen anything else inside the method body that would need changes. And also from my understanding, we're just caring about the jump target body, not its attributes.

I'd personally like to know if always setting it to Public | Static causes any side effects. Preparing a HarmonyTests test case right now for future reference.

[Kittyfisto]

I've just tested a build after the latest fix has been merged and the above example is now working for me :)
@pardeike I guess you can close this issue now.

[pardeike]

Excellent!