Giter Site home page Giter Site logo

Comments (2)

SimonCropp avatar SimonCropp commented on September 20, 2024

Raised by @SimonCropp

@fhalim this would seem to make sense, although i am not fully across the RabbitMQ codebase. So I have a few questions

  • is there any impact to people using the existing implementation
  • does any doco need to be updated. for example the xmldocs for that class
  • is it possible to have a failing unit or integration test that illustrates the problem? then we apply the fix and watch it go green.

CC @andreasohlund

from nservicebus.rabbitmq.

SimonCropp avatar SimonCropp commented on September 20, 2024

Raised by @fhalim

As it turns out, the test When_sending_a_message_over_rabbitmq#Should_throw_when_sending_to_a_nonexisting_queue tested this scenario, but it was set to Ignore. Modified RabbitMqUnitOfWork wraps cases where the connection gets closed due to the exchange not existing in a QueueNotFoundException.

The tests in When_sending_a_message_over_rabbitmq were failing due to the recipient exchange not being created when the queue was being created. That has been corrected.

from nservicebus.rabbitmq.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.