calling request.parse_formvars twice results in GET parameters added twice

[akrherz]

calling request.parse_formvars twice results in GET parameters added twice

[cdent]

Hmmm. Good question. This section of the code is from long before I was involved so it hard to guess the reasoning.

Are you changing the query string in the middleware, or simply doing other things in reaction to what is already there?

If if is the later, would it work to delete paste.parsed_formvars at the end of the middleware (after parse_formvars is called) so that the second time it is called, there's no cached state?

Another option might be to do a method check in the middleware and if it is a GET then don't use parse_formvars at all, just parse_querystring. (I'm assuming here that you're not using a body in the GET request...)

[akrherz]

Thank you for the response.

Are you changing the query string in the middleware, or simply doing other things in reaction to what is already there?

I'm just doing middleware stuff, like looking for naughty content and doing some conditioning to remove downstream boilerplate code.

If if is the later, would it work to delete paste.parsed_formvars at the end of the middleware (after parse_formvars is called) so that the second time it is called, there's no cached state?

That's a clever idea thanks.

I still think this is a bug though and that reprocessing should be removed :) I'll PR it now.