Can't convert BigInt to Decimal without setting its value to 0

[James103]

Can't convert BigInt to Decimal without setting its value to 0

[Patashu]

Woah, I haven't seen this '2n' thing before. Is it a new Javascript feature?

[James103]

Woah, I haven't seen this '2n' thing before. Is it a new Javascript feature?

The syntax used describes something called BigInts, which are supported on the most recent version of all major browsers. BigInts effectively allow storing numbers much larger than 2¹⁰²⁴ with full precision (down to the nearest whole number), with their size effectively only being limited only by available memory.

For more information on BigInts, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt

[Patashu]

Cutting edge! I'll take a look at supporting BigInts if I find the time and mood.

[James103]

You can convert a BigInt to a String with String(bigint) or bigint.toString() and you can construct a Decimal from a string of digits with new Decimal(string). However, Decimal.fromString fails to properly parse strings of digits that are more than 309 digits long, as such strings become Infinity when coerced to Number.

Number("1".repeat(309))
1.1111111111111112e+308

Number("1".repeat(310))
Infinity

[Patashu]

I guess it'd be sufficient to detect the string is longer than 300 digits, grab the first 18 of them, and turn it into mantissa and exponent.

[1231234md5]

#145 will fix it

[jakub791]

I guess it'd be sufficient to detect the string is longer than 300 digits, grab the first 18 of them, and turn it into mantissa and exponent.

Couldn't you toString() the bigint, remove the n from the string then let toString() method do it's job as usual?

[1231234md5]

I guess it'd be sufficient to detect the string is longer than 300 digits, grab the first 18 of them, and turn it into mantissa and exponent.

Couldn't you toString() the bigint, remove the n from the string then let toString() method do it's job as usual?

but that's what #145 does.