Header for each month

[patchthecode]

Header for each month

[patchthecode]

Hmm. By the way, I went through all your commits on your fork.
It seems all of the bugs you have fixed, I have worked on and fixed.

Also worked on performance issues on device. Thanks for all the help thus far.

[patchthecode]

Thanks very much.
Ok trying to understand one part of what you said.

1. What did you mean by the empty space between the months?
2. Can you maybe give me a screenshot with a rough drawing of where you'd like the header to be?

With these 2 pieces of info and can think up a solution.

[patchthecode]

Also, Basically, what kind of header are we looking at? text/image/... ?

[edopelawi]

Right. Here's a screenshot:

The "empty space" that I meant was the area where I put the red text. I wanted to add a similiar UIView with the top header (MAY 2016) between there... what do you think?

[patchthecode]

Ok. i see the problem.
I guess you have vertical scrolling enabled.
And, you have the monthOut dates visibility to be false.

Alright, currently it has no headers. But I was going to do an update for it anyway. Will work on something when i get back.

[edopelawi]

Yes, I changed the scrolling mode to vertical and hide the dates besides .ThisMonth. I forgot to tell you that, my apologies 😅

I see... hey, what if I try to implement it myself and shoot some pull requests when I'm done? I need it to be done this week - and meanwhile, you can focus on other enhancements. If you don't mind, of course 😉

[patchthecode]

Implementation completed for vertical scrolling.
just doing last minute testing.

horizontal scrolling to be done.

[patchthecode]

Updated to version 3.0.0 which should resolve this. Let me know how if it solved it.

[edopelawi]

Apologies for the late response, but I'm currently occupied with my own project 😅 I'm currently using my own patch to add the header in my own fork 😄 I'll try to the new version it this weekend, is that okay?

That being said, I found that result of delegate's calendar(_:, canSelectDate:, cell:, cellState:) method is not used, since the place where it's called (in collectionView(collectionView:, shouldSelectItemAtIndexPath indexPath:), I recall) always returns true instead of using the result. I could create a pull request if you want to, but I afraid my fork deviates too far away from the original 😬 and it wouldn't take much to fix that bug, IMO 😄

[patchthecode]

Alright. cool. And thanks for finding the other one. I'll track it on this issue #24
Closing this one

[edopelawi]

Whoa you read my fork? That's pretty cool! :) keep up the good work man!