Giter Site home page Giter Site logo

Comments (14)

patchthecode avatar patchthecode commented on May 2, 2024 1

Yea ok i have this issue fixed. Im testing it now to make sure i dont break anything else

from jtapplecalendar.

patchthecode avatar patchthecode commented on May 2, 2024

Checking this out now.

from jtapplecalendar.

akabab avatar akabab commented on May 2, 2024

I actually tried to put it in viewDidAppear, it's actually working but not each time, I'm thinking maybe the calendarView did not finished initializing when I receive viewDidAppear call. It's concurrency issue, is there any call made my the calendar I could rely on when it did finish loading (eg. calendarDidLoad) ?

from jtapplecalendar.

akabab avatar akabab commented on May 2, 2024

Great!, you're about to push it ?

from jtapplecalendar.

patchthecode avatar patchthecode commented on May 2, 2024

I can push it yes. But, I cant do an official release till i test it.
Currently, the new code fix has a crash for individuals using vertical scrolling.

I'm trying to get this all wrapped up by Saturday. fingers crossed.

from jtapplecalendar.

akabab avatar akabab commented on May 2, 2024

Alright ;) thanks

from jtapplecalendar.

patchthecode avatar patchthecode commented on May 2, 2024

Ok. Hey, I've finished testing the latest patch.
In order to fix the concurrency issues, i had to do some changes to the way we do

calendarView.numberOfRowsPerMonth = 6

I have now made it more like Apple's UITableView. The number of rows is now setup in the configure method. I will push this to master branch now. Would you be able to test it from master branch? or are going to wait for release 3.0.2?

I am pausing the release to handle the other issues, but the fix will be available on master branch.

from jtapplecalendar.

patchthecode avatar patchthecode commented on May 2, 2024

Committed and pushed master branch. The example of how to accomplish your task is added to the sample project.
Take a look in the viewDidLoad() function.

from jtapplecalendar.

akabab avatar akabab commented on May 2, 2024

I'm not sure to understand the relation between numberOfRows and the scrollToDate on viewDidLoad. You're not calling scrollToDate in your exemple. Anyway I guess I'm gonna wait for realease, I'm using the pod.

from jtapplecalendar.

patchthecode avatar patchthecode commented on May 2, 2024

Ok. My bad, i didnt explain it clearly.
you are correct. NumberOfRows and scrollToDate and totally unrelated.

However in the next release, there will be a change to the way numberOfRows is setup. So i was just giving you a heads up on the changes to expect.

Your scroll to date issue will be resolved. But you will also have to make one small change on in the configureCalendar function.

I'll Release the update later today. Let me know if anything else is breaking.

from jtapplecalendar.

akabab avatar akabab commented on May 2, 2024

No problem, thanks!

from jtapplecalendar.

patchthecode avatar patchthecode commented on May 2, 2024

updated to version 4.0.0
Update your pod and let me know if you're still experiencing the problem.

You can scroll to your date using the scrollToDate function.
That function has a number of options you can choose from as shown here (Scroll to question 4)

If this is no longer an problem then you can close this issue.

from jtapplecalendar.

akabab avatar akabab commented on May 2, 2024

Seems to be working! 👯
Btw, you should remove JTAppleCalendarDelegates.swift line 269 -> print(indexPath)
Be free to close that issue, great job.

from jtapplecalendar.

patchthecode avatar patchthecode commented on May 2, 2024

oops... >_<
yea.. i'll remove it. it must have been late, i forgot to remove it

from jtapplecalendar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.