Giter Site home page Giter Site logo

Comments (4)

iShawnWang avatar iShawnWang commented on June 1, 2024

Update :

  • All my model is subclass of AVObject which reserve property uuid internal
  • So create a child entity named UserPhoto which subclass AVObject to contain @property (copy,nonatomic) NSString *avatarPath; will not work.
  • May be the only way is to fork and modify the source code , but it takes extra effort to maintain the code when FastImageCache official repo update :(

from fastimagecache.

mallorypaine avatar mallorypaine commented on June 1, 2024

Would definitely appreciate a PR that fixes this issue. With a small baby at home, I rarely have time to work on fixes myself anymore, but if you write a PR, I'll work with you to get it merged.

from fastimagecache.

iShawnWang avatar iShawnWang commented on June 1, 2024

Yeah, it is really more important to be a good father.

  • I just create a new pull request :
  1. I add prefix FIC for all the property and method in FICEntity protocol
  2. I update FICImageCache.m with little change above
  3. I update FICDPhoto which confirms to protocol FICEntity in FastImageCacheDemo
  4. The new code works great in FastImageCacheDemo and my App.

The problem is if this PR is merged to master ,all the developers using this lib may take some unnecessary time to modify their classes which confirm to FICEntity.

Hoping i am doing this the right way. 😊

from fastimagecache.

mallorypaine avatar mallorypaine commented on June 1, 2024

I merged your PR.

from fastimagecache.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.