Comments (2)
What would be the proper fix to this? Are you suggesting equality on absolute paths?
If you add links to places of the codebase where this can be fixed, I'll make sure we tackle this one in the next Scala Center hackathon 😉.
from better-files.
I honestly think this is fine - we check if 2 directories are equal if their md5s are equal. in better-files, we get a deterministic md5 for directory by recursively listing and hashing a directory. This is almost impossible to have a false positive unless we find an md5 hash.
That being said, the correct way would be to recursively list both (but an iterator not actually load all the recursive paths in memory) and zip these 2 iterators and compare them one by one...
The code to look at is File.isSimilarContent
from better-files.
Related Issues (20)
- make File serializible HOT 3
- Calling size on a broken symlink throws a NoSuchFileException,
- Switch to new codecov reporter
- Scala3 version HOT 6
- Support scala-native? HOT 2
- Use common settings style HOT 1
- Stream closed with Scala 2.12.15
- usingTemporaryDirectory should return `U` instead of `Unit` HOT 1
- is there a way to read huge gz csv file line by line of this package? HOT 1
- Make build pass on windows
- Make all side-effecty APIs use parens
- Add error handler to File.walk
- Imlement features from sbt IO
- Write self cleaning tests - no mutable vars
- Enable warnings for Scala 2.13 and above
- Generate scaladoc for all Scala versions
- Port ShapelessScannaerSpec to Scala 3
- scalaformat organize imports
- changeExtensionTo does not account for multiple dots in file name
- Directory Traversal Issue in File.unzipTo HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from better-files.