Always returns false

[patik]

Always returns false

[patik]

Can you try withinviewport(document.getElementById('hello')) ?

If that doesn't work, can you post the code somewhere (preferably a reduced test on Codepen, JSBin, etc) so I can try and debug it?

[deliver2manish]

I used this plugin and I also face same problem.

console.log(withinviewport(document.getElementsByClassName("quest-grid-image")[i])) always returns false even if the element is visible.

The element id is correct. I double checked it.

[patik]

I can't reproduce the bug in my own demos so I wonder if some other CSS in your page is affecting it. Can you link to the page or put a quick demo in Codepen/JSBin? Are there any iframes involved?

[deliver2manish]

I use it for this website: http://www.seenit.in. I included the ('js/jquery.withinviewport.js', 'js/withinviewport.js') files and used it as shown below:

$(window).bind("scroll", function() {
    var i;
    for(i=0;i<12;i++){
        console.log(withinviewport(document.getElementsByClassName("quest-grid-image")[i]));
    }
});

It always prints false on the console log, even if the element is fully visible on the screen.

[patik]

This is now fixed with v1.0.0. Thanks for including the example code, @deliver2manish. I believe the issue was that the <div> you were targeting was inside an <a> (i.e. an inline element, rather than a block) and that tripped up the part of my code that calculates the target element's position. I'm using a faster and more robust method now.

[deliver2manish]

Thanks. It fixes the bug for me.

On Mon, Aug 3, 2015 at 4:19 AM, Craig Patik [email protected]
wrote:

This is now fixed with v1.0.0
https://github.com/patik/within-viewport/releases/tag/1.0.0. Thanks for
including the example code. I believe the issue was that the

you
were targeting was inside an (i.e. an inline element, rather than a
block) and that tripped up the part of my code that calculates the target
element's position. I'm using a faster and more robust method now.

—
Reply to this email directly or view it on GitHub
#16 (comment)
.

"Stay Hungry, Stay Foolish"