Giter Site home page Giter Site logo

Comments (5)

AutoSponge avatar AutoSponge commented on August 24, 2024 1

The problem with string representations is that you will often get false negatives. The nodes could report unequal because attributes are in different order. We only care about the attribute keys and values being equal.

var r = document.createRange()
var n1 = r.createContextualFragment('<div class="same" data-test="elm"></div>')
var n2 = r.createContextualFragment('<div data-test="elm" class="same"></div>')
n1.isEqualNode(n2) //true
n1.firstChild.outerHTML === n2.firstChild.outerHTML //false

from morphdom.

AutoSponge avatar AutoSponge commented on August 24, 2024

morphdom does not currently use a virtual dom. DOM equality is already defined: https://dom.spec.whatwg.org/#concept-node-equals. If you want to speed up diffing, you can use #.isEqualNode() or your own implementation like the example in #69.

from morphdom.

francescoagati avatar francescoagati commented on August 24, 2024

i understand but my is only a curiosity. is a.innerHTML == b.InnerHTML && a.outerHTML == b.outerHTML a comparson between string and more performant?

from morphdom.

francescoagati avatar francescoagati commented on August 24, 2024

right thanks :-)

from morphdom.

patrick-steele-idem avatar patrick-steele-idem commented on August 24, 2024

It would be nice if browsers support a shallow comparison of a DOM node (don't compare child nodes). Something like the following node.isEqualNode(otherNode, {depth: 0})

In the mean time, I think the best option will be to loop over the attributes and compare the tag name.

from morphdom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.