Giter Site home page Giter Site logo

Add `module-info.java` about hkdf HOT 4 CLOSED

patrickfav avatar patrickfav commented on June 14, 2024
Add `module-info.java`

from hkdf.

Comments (4)

patrickfav avatar patrickfav commented on June 14, 2024 1

A PR would be very much appreciated. The reason this repo doesnt see any relevant activity is that HKDF is a quite straight forward and simple algorithm and I feel it does everything it needs. That doesnt mean its obsolete, just that I dont think it needs more than what it is.

from hkdf.

patrickfav avatar patrickfav commented on June 14, 2024 1

Released as https://github.com/patrickfav/hkdf/releases/tag/v2.0.0, sorry for the delay

from hkdf.

overheadhunter avatar overheadhunter commented on June 14, 2024

Sure, so which build system is being used here? nevermind, I don't know why I had the impression there were Gradle files in this repo 🙈

from hkdf.

overheadhunter avatar overheadhunter commented on June 14, 2024

I encountered a little problem: You have multiple projects that use the package at.favre.lib.crypto (e.g. bcrypt, to name another). If downstream projects (transitively) rely on more than one such library, they will end up with what is called a split package, which is no longer allowed.

There is no workaround. You need to rename the package. Which is a breaking change, so this needs to be released as a major version, according to semver.

Two questions arise:

  1. First and most importantly: Are you even willing to publish a breaking change?
  2. Which module name should we use? Usually related to the Maven coordinates, i.e. at.favre.lib.hkdf
  3. Which package name should we use? De-facto standard is to start with the module name to avoid split packages, i.e. at.favre.lib.hkdf.*

from hkdf.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.