Giter Site home page Giter Site logo

Comments (4)

hafu avatar hafu commented on August 15, 2024 1

I'll will check on Monday. I assume I's because the users home is tried to changed by the Ansible user module with a process running as the user and this fails.

It it is the case, I could add a check if the users current home will be changed and stop the promtail process before running this task. But this would add some complexity to the role only to change the users home.

from ansible-role-promtail.

patrickjahns avatar patrickjahns commented on August 15, 2024

@shinebayar-g
Thanks for reporting - I was not expecting that change to create issues. I've created a test case for catching regressions in the future #141

@hafu
I'd gladly appreciate if you provide a fix for the regression - thank you :-)

from ansible-role-promtail.

hafu avatar hafu commented on August 15, 2024

I could reproduce the issue. And came up with two options:

  1. As mentioned by @shinebayar-g #138 (comment) omitting the home. This would not touch the home of the user on existing installations (/) and on new installations it would be the default /home/promtail or /home/{{ promtail_system_user }}.
  2. Check for the user and if exists make sure there is no process running by stopping promtail when the home changes. I've added some additional tasks: a481b4d

What do you think?

from ansible-role-promtail.

patrickjahns avatar patrickjahns commented on August 15, 2024

Thanks for reaching out - personally I believe number 1) is the less intrusive one and with the less maintenance overhead in the long run.

from ansible-role-promtail.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.