Giter Site home page Giter Site logo

Comments (8)

jnm2 avatar jnm2 commented on August 26, 2024

@paul1956 Do you have specific steps I can take? I can't reproduce this problem. This is what I get with Convert > Convert Folder:

image

from csharptovb.

jnm2 avatar jnm2 commented on August 26, 2024

Another try:

image

This is using commit 945b37f which is currently the tip of master.

from csharptovb.

paul1956 avatar paul1956 commented on August 26, 2024

I think I fixed it it the last commit, but the total count may be off now in some cases.

from csharptovb.

paul1956 avatar paul1956 commented on August 26, 2024

Actually it is an issue where the processing code skips some files (auto generates, Ignored...) in the original code total is decremented. I am testing now.

from csharptovb.

paul1956 avatar paul1956 commented on August 26, 2024

image
This is when complete, the total is not being decremented.

from csharptovb.

jnm2 avatar jnm2 commented on August 26, 2024

@paul1956 I still don't understand, I'm sorry. Where in the codebase before or after my PRs was the total being decremented? I can't find it even before my first PR. I see only one decrement in the codebase and it is not decrementing the TotalFilesToProcess variable which is what drives that message.

I tried running commit e4209a6 which is the commit before my first PR merged. I got this:
image

So I'm pretty sure this is not a regression from making it async but rather an existing underlying problem.

from csharptovb.

paul1956 avatar paul1956 commented on August 26, 2024

@jnm2 Thanks I will look again, this was done a long time ago, Now at least you get something reasonable. I have a simple solution that will not break your changes.

from csharptovb.

paul1956 avatar paul1956 commented on August 26, 2024

I am going to close,I think I broke the decrement a long time ago when I added the code to GetFileCount and that is where it needs to be fixed.

from csharptovb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.