Comments (8)
@paul1956 Do you have specific steps I can take? I can't reproduce this problem. This is what I get with Convert > Convert Folder:
from csharptovb.
Another try:
This is using commit 945b37f which is currently the tip of master.
from csharptovb.
I think I fixed it it the last commit, but the total count may be off now in some cases.
from csharptovb.
Actually it is an issue where the processing code skips some files (auto generates, Ignored...) in the original code total is decremented. I am testing now.
from csharptovb.
This is when complete, the total is not being decremented.
from csharptovb.
@paul1956 I still don't understand, I'm sorry. Where in the codebase before or after my PRs was the total being decremented? I can't find it even before my first PR. I see only one decrement in the codebase and it is not decrementing the TotalFilesToProcess variable which is what drives that message.
I tried running commit e4209a6 which is the commit before my first PR merged. I got this:
So I'm pretty sure this is not a regression from making it async but rather an existing underlying problem.
from csharptovb.
@jnm2 Thanks I will look again, this was done a long time ago, Now at least you get something reasonable. I have a simple solution that will not break your changes.
from csharptovb.
I am going to close,I think I broke the decrement a long time ago when I added the code to GetFileCount and that is where it needs to be fixed.
from csharptovb.
Related Issues (20)
- Array () missing for converted types HOT 1
- Converting a string containing \" HOT 3
- False Alarm
- 'Record' conversion fail. HOT 1
- Compilation errors and runtime error HOT 10
- Project file not converted when convert solution HOT 4
- Problem with Is and = only when convert solution HOT 2
- About ++ or -- operator HOT 3
- DarkMode - Slight tweaks HOT 1
- Some bugs when converting C# snippets to Visual Basic HOT 1
- Fail to assign the right local variable Split from #74 HOT 7
- Custom events conversion issues HOT 4
- Missing AddressOf HOT 5
- OverFlow Conversions HOT 3
- "Range Sugar" issue... HOT 1
- Please don't change public API names HOT 3
- Interface event definitions converted as "private" HOT 1
- Property and Interface issues HOT 5
- Pattern matching issues HOT 4
- Converting C# string literals to VB is missed up
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from csharptovb.