close resources

[paulcwarren]

close resources

[paulcwarren]

Whoops. That is an oversight...We are targetting Java 8.

[paulcwarren]

Please see this commit and this commit.

[bilak]

@paulcwarren it's still big mess. when are the connections closed? As example look at this:

rs = datasource.getConnection().getMetaData().getTables(null, null, "BLOBS", new String[] {"TABLE"});

It could be rewritten to something like this:

try (Connection connection = datasource.getConnection()){
   try (ResultSet rs = connection.getMetaData().getTables(null, null, "BLOBLS", new String[]{"TABLE"})){
      ... do something other and connection and resultset will be released by try/catch autocloseable block.
   }
}

that also applies to Statement class

[jeffpak]

@bilak Please see this commit. We didn't implement the fix exactly as you suggested, but decided instead to use the jdbc template. Does this satisfy your concerns?

Best,
Jeff & Paul

[paulcwarren]

Haven't heard back on this so I assume the later commit resolved the issues.