Prepare initial release

[paulrobertlloyd]

Prepare initial release

[alienlebarge]

Thanks for the mention and the offer to collaborate.
I may try it out tonight.

[paulrobertlloyd]

Fixed a pretty gnarly bug (no text would be output in bare text strings!), have now got full test coverage, added a number of different tests, and written up some documentation.

Take a look and let me know if this all makes sense, and that I’ve covered everything!

[paulrobertlloyd]

Baring any other issues, looks like this package is ready to be published. Two questions:

1. Would you like to be add to the contributors field in package.json? If so, with what details?

2. What do you think to the name of this package? I note your function was called socialHandle, maybe it should be that? Here are some options I’ve considered:

   • markdown-it-social-mention
   • markdown-it-federated-mention
   • markdown-it-handle
   • markdown-it-social-handle
   • markdown-it-user-handle
   • markdown-it-username-handle
   • markdown-it-account-handle

   Including ‘handle’ is perhaps a better option. I don’t know if there’s a more specific name for the @username@host format. Mentions may happen as a result of using this plugin, but not necessarily, so maybe that shouldn’t be included in the name?

[paulrobertlloyd]

Nope… found another bug… need to add some more tests for strings that contain links, but not with a matching string.

[paulrobertlloyd]

Fixed!

[alienlebarge]

1. Would you like to be add to the contributors field in package.json? If so, with what details?

Nope thanks. You are the personne who does the job ;)

2. What do you think to the name of this package? I note your function was called socialHandle, maybe it should be that? Here are some options I’ve considered:

• markdown-it-social-mention
• markdown-it-federated-mention
• markdown-it-handle
• markdown-it-social-handle
• markdown-it-user-handle
• markdown-it-username-handle
• markdown-it-account-handle

Including ‘handle’ is perhaps a better option. I don’t know if there’s a more specific name for the @username@host format. Mentions may happen as a result of using this plugin, but not necessarily, so maybe that shouldn’t be included in the name?

I agree with you.
For me, the mention is the whole post: the handle and the content.

I have done some researche and "handle" seems to be the most common word to describe @username@host.

• https://www.google.com/search?q=user+handle
• https://www.google.com/search?q=social+handle

As this plugin converts the handle and not the mention, using the word "handle" in the name seems more appropriate than "mention".
I won't use the word social. The site is not always a social network. Vimeo ([email protected]) is not really a social network.

For me markdown-it-user-handle and markdown-it-username-handle are the two best one.

[alienlebarge]

I get errors with the plugin. Apparently it's due to something in the markdown's front matter.
alienlebarge/alienlebargech-v3#178

[paulrobertlloyd]

I’ve added an additional check for children before checking for children[0].type, which may fix this.

Also note I’ve updated the package name to markdown-it-handle.

[alienlebarge]

I’ve added an additional check for children before checking for children[0].type, which may fix this.

Nice !
Sadly, I have updated the plugin but still get the error. Will investigate when I get time

Also note I’ve updated the package name to markdown-it-handle.

👌 perfect

[alienlebarge]

I Found the problem alienlebarge/alienlebargech-v3#178 (comment)

Everything is ok for me now 😅

[paulrobertlloyd]

Released!