Coherent slide/controller message API

[paulrouget]

Coherent slide/controller message API

[hsablonniere]

You forgot the details/comments/notes in Slide->Controller.
onstage shell needs to display them...

[paulrouget]

I like the idea of having a more efficient protocol. Better to use the wiki:

https://github.com/paulrouget/dzslides/wiki/protocol
(didn't add the notes stuff)
What do you think?

[hsablonniere]

About notes stuffs, I think it could be sent along with cursor to a poll response in the currentSlide(cursor) message

[pci]

I'm not so sure about sending notes with the poll response, it's fine for the current slide design, but someone might what to use it for things like video subtitles from a slide (for example) and so it wouldn't nicely fit with poll response. It probably needs it's own message.

[hsablonniere]

Hum, we're talking about slides notes. They should be written only for onstage and preparation purposes. I'm not sure I understand the link with video subtitles.

[pci]

Sorry, bad example. It's just if it's linked to the poll response then it can only change when forward() is called. A better example might be that after 5 mins on a slide the slide notes change to "move on!" :)

[hsablonniere]

Lol. Not a bad idea...

I think that only one set of notes is needed by slide, so if it only change with forward, I'm OK with it.

[paulrouget]

We should keep it simple and understandable. getNotes(cursor) should be enough I think.

[paulrouget]

(sorry, closed the bug by mistake)

Just updated the protocol. Serious changes. I use the usual protocol syntax (not a js-like one).
Please review and comment.

(I am not sure about the "content" messages. Do we need that?)

[hsablonniere]

I don't see any problems for me.

Content messages may be useful in some cases maybe with the coming mobile remote UI and WS/server events stuffs...

[paulrouget]

New update. Serious changes.
https://github.com/paulrouget/dzslides/wiki/protocol

Comments are welcome!

[hsablonniere]

Ok for me. The incremental feature will handle cursors so we can manage them via future protocol.

[hsablonniere]

I sent a PR for new incremental feature. onstage needs to be adapted to work with it.

I think we can start working on protocol now and manipulate cursors between windows instead of slide idx.

[hsablonniere]

I sent a pull request for the protocol. Let me know what you think of it.

[hsablonniere]

I added START and END messages on the wiki : https://github.com/paulrouget/dzslides/wiki/protocol.

[paulrouget]

Good catch.

[pci]

Sorry for the long absence, looks like I've got some catching up to do!

APIs look great.

One note: rather than have all controllers requesting the notes every time wouldn't it be better to allow the slides to send the NOTES html_content message without it requiring a request (more like CURSOR)?

[pci]

Oh, also do we want a TOGGLE_FULLSCREEN command? As there isn't any chrome for user interaction on the actual slide (issue #28)

[paulrouget]

One note: rather than have all controllers requesting the notes every time wouldn't it be better to allow the slides to send the NOTES html_content message without it requiring a request (more like CURSOR)?

Not sure we want to send the notes every time we update the slides. Only something like onstage.html would need such a feature, and in the future, if we want to support websockets, that would be too much to send at every update.

Oh, also do we want a TOGGLE_FULLSCREEN command? As there isn't any chrome for user interaction on the actual slide (issue #28)

That will happen in issue #28

[pci]

Fair enough :)

[hsablonniere]

I do agree with Paul on notes.

[hsablonniere]

Protocol stuffs solved! see cefda59