Giter Site home page Giter Site logo

Comments (20)

hsablonniere avatar hsablonniere commented on August 15, 2024

I also thought about that when I did some testing on onstage, incremental and protocol. Since I don't use video (yet) I didn't point it but...

I think you're right Philip. This is a serious issue. I would be in favor of not playing the video at all and sending "STOP_CONTENT" instead of "MUTE". What do think ?

from dzslides.

pci avatar pci commented on August 15, 2024

I agree an API solution is probably the way to go. The problem is that if "STOP_CONTENT" is called at the beginning, the javascript still launches the video when the slide comes into focus. Even if "STOP_CONTENT" is called at each slide turn they'll probably be a gap where the video/audio plays.

We probably need a permanent message like "NO_VIDEOS". But I quite like seeing the video that's coming up (for example try the new style template.html) which is why I favor "MUTE", however it can lead to the computer running three videos at once!

from dzslides.

hsablonniere avatar hsablonniere commented on August 15, 2024

Humm, embarassing. Your making a point. I think this should be tested in real conditions or almost and see which is be best and usable solution.

I'm almost convinced... :p

from dzslides.

paulrouget avatar paulrouget commented on August 15, 2024

By default, video and audio should autoplay. In some conditions (onstage) we don't want the autoplay.
Not sure we want to use the protocol for that.

What if, in the URL, we add something like slides.html?autoplay=false?

from dzslides.

hsablonniere avatar hsablonniere commented on August 15, 2024

I'm not against URL parameters, I think even if we use that and not protocol it should be addressed in the same issue/branch.

Philip wanted muted videos, I don't really care on the point, do we wan't autoplay=false or mutemedias=true or anything else...

from dzslides.

pci avatar pci commented on August 15, 2024

Url parameters are fine by me.

My only reason for suggesting mute over not playing the video is to give the presenter a head's up on which video is on the next slide, as a large number of videos just start black. But I don't feel strongly on the point and in some situations you can have the computer trying to play 3 videos at once (bad for low end/mobile!). So maybe autoplay=false is the way to go.

It's probably good to have any potential URL parameters on the same wiki page as the API so people don't have to route around for all the information.

from dzslides.

hsablonniere avatar hsablonniere commented on August 15, 2024

You could use poster attribute which allow you to choose the thumbnail displayed to replace black screen.

I agree with you that playing 3 videos at once just for that is not a good idea.

I also agree on putting URL parameters in the same wiki page as the API.

from dzslides.

paulrouget avatar paulrouget commented on August 15, 2024

yes, yes and yes. Go for it!

from dzslides.

hsablonniere avatar hsablonniere commented on August 15, 2024

I have a working test for template.

How do we handle this in onstage. Future should have autoplay=false but what about present and remote ? If we want to enable auto play on remote no problem but how do we disable it on present without reloading ? If it safe to assume that onstage users will always use the remote popup ? I'm not sure about that...

Can we handle this stuff in the same PR/branch as the new protocol ?

from dzslides.

pci avatar pci commented on August 15, 2024

er..... good point - URL parameters don't really switch on and off so well!

The only (very hacky) way I can think of doing switching through URL parameters would be to use the history API to append the hash, e.g. history.pushState(stateObj, "page 2", "foo.html#autoplay=false"); and then have the slides check the hash on every slide change! But this would lead to pretty opaque and easy to break code.

Are we back to proposing an API solution then?

from dzslides.

paulrouget avatar paulrouget commented on August 15, 2024

No autoplay on present, even if remote is not opened yet.

from dzslides.

paulrouget avatar paulrouget commented on August 15, 2024

I don't think autoplay ever needs to be toggled.

from dzslides.

hsablonniere avatar hsablonniere commented on August 15, 2024

Ok for me.

So autoplay=0 for present and future and default behaviour for remote.

I did some tests and 0/1 is better than true/false. It's easier to convert to real boolean than text values.

I'll create a branch and a PR this evening.

from dzslides.

pci avatar pci commented on August 15, 2024

Ok, was going to say I'll update the wiki page but I see it's already been done :)

from dzslides.

paulrouget avatar paulrouget commented on August 15, 2024

@pci Can you please verify that it is fixed now?

from dzslides.

pci avatar pci commented on August 15, 2024

Quick work hubert, great stuff! I'll check it out tonight

from dzslides.

pci avatar pci commented on August 15, 2024

Seems to work brilliantly!

The "!!+" had me stumped for quite a while :) That's a very neat trick.

The wiki said the default for autoplay was 0 (ie not playing) so I've changed it over.

Very happy to close this bug, great work!

from dzslides.

hsablonniere avatar hsablonniere commented on August 15, 2024

Yeah nice reflex for the wiki, thx...

from dzslides.

paulrouget avatar paulrouget commented on August 15, 2024

Thanks guys.

from dzslides.

hsablonniere avatar hsablonniere commented on August 15, 2024

About the !!+ : I hesitated but I thought keeping all kind of parameters as string would be simpler since they're passed by the URL.

The easiest or shortest way to have string to kinda boolean was using 0 and 1 and this double implicit conversion.

Maybe some explanations in the documentation would be helpful.

from dzslides.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.