Comments (14)
@alantoa @felippepuhle
If you have any changes which you think should be merged and released - create your pull request, please.
I don't have much time to work on my library because of the current situation in Ukraine, but I'll review all pull requests and create new releases.
from react-native-awesome-gallery.
I was about to reply that I was having the same issue but I went ahead and downgraded all of my dependencies to the same as the example: https://github.com/Flair-Dev/react-native-awesome-gallery/blob/main/example/package.json
And it works. The culprit for me was react-native-gesture-handler
, which I had as 2.2.0
but the example package is on the previous major version, 1.10.1
.
Downgrading a major version may or may not be acceptable for your use cases. It would be great if this library could be updated for the new API.
from react-native-awesome-gallery.
👋 Hi, everyone, It's been a few days and many people still have this problem, I will simply answer it.
@mtflud Vertical doesn't working on emulator, The main problem that velocityY
& velocityX
is always 0 under the emulator, you can set true
, it will work on emulator. Souce Code
@gerryfletch @nateguy @FadiAboMsalam This library is awesome, I also learned a lot from this library. In fact, react-native-gesture-handle
v2 API is backwards compatible, but there are some incompatible methods in this library, I already know some problem, so I plan to rewrite this lib using react-native-gesture-handler v2, and will add some features and fix some bugs, I will notify your of progress.
Thank you all! 🤝
from react-native-awesome-gallery.
You can't use react-native-modal
, beacuse modals are not located under React Native Root view in native hierarchy, ModalView will block gesture.
This library does not support scaling, This is only a image gallery, if you use @react-navigation/stack
, you can use eact-navigation-shared-element.
Now I'm implementing the image lightbox effect use react-native-reanimated
& react-native-gueture-handle
, But it's still under development.@usamaabutt
from react-native-awesome-gallery.
@alantoa is there anything we can do to help you on that rewrite? we don't really understand or know what are the incompatibilities but we can allocate some hours trying to fix it as well, thanks!
from react-native-awesome-gallery.
@felippepuhle Hi!
I will contact you when I need help!
Thank you!🤝
from react-native-awesome-gallery.
Fixed in v0.3.0 by migration to RNGH v2
from react-native-awesome-gallery.
Hi, I guess your code is running on the emulator.
On the emulator, I think translationY
is a bug, I suggest you test it on a device. @usamaabutt
This library is already running in my project, I feel good, thanks author.
If you have any questions, I'd be happy to answer. :)
from react-native-awesome-gallery.
Hi @alantoa Thanks for your reply but unfortunately it is not working on a real iOS device I have just tested it now. And another issue is swipe-down
gesture is not smooth as it should be. Can you please share your particular piece of code of the component in which you have used it?
Here's mine:
export const ImageZoomView: FunctionComponent<ImageProps> = ({
openZoomViewer,
image,
closeZoomViewer,
}) => {
const ref = useRef<GalleryRef>(null);
const renderItem = ({
index,
item,
setImageDimensions,
}: RenderItemInfo<{ item: string }>) => {
return (
<ImageViewContainer>
<ThreadCloudinaryImage imageId={item} />
</ImageViewContainer>
);
};
return (
<CustomModal isModalVisible={openZoomViewer} backdropOpacity={1}>
<Gallery
ref={ref}
data={image}
renderItem={renderItem}
onSwipeToClose={closeZoomViewer}
disableSwipeUp={true}
hideAdjacentImagesOnScaledImage={true}
style={{ alignSelf: 'center' }}
/>
</CustomModal>
);
};
from react-native-awesome-gallery.
Hi, other than swipe-down
, other gestures it's OK ?
I see you example code, In addition to <CustomModal/>
, everything else is fine, <CustomModal/>
is react-native-modal
? @usamaabutt
Maybe it's your modal affects swiper down gesture, I suggest you running Example.
from react-native-awesome-gallery.
Yes @alantoa <CustomModal/>
is react-native-modal
. @alantoa I am using this library just to have an image zooming effect by pressing an image in the app. So, every time I have a single image in the array. So do you think it will fit according to my scenario?
from react-native-awesome-gallery.
@usamaabutt did you figure a fix for using this lib under react-native-modal for onSwipeToClose ?
I am facing same thing
from react-native-awesome-gallery.
I'm having the same issue and I'm not even using Modal
from react-native-awesome-gallery.
Can confirm this is an issue when using react-native-gesture-handler
v2. API is supposed to be backwards compatible, but vertical gestures are not being properly detected. v1 works fine
from react-native-awesome-gallery.
Related Issues (20)
- Buggy behavior while changing from portrait to landscape on zoomed in images HOT 3
- Add loading component HOT 1
- Suggestion: set index with animation HOT 2
- translateX offset, image disappear on pan HOT 4
- Resizable image
- Bug: gallery does not work if using containerDimensions prop value changes HOT 1
- react-native-reanimated v3 support HOT 2
- Images rendering at lower resolution with SharedElement transition HOT 5
- Unable to run the example code, or use this module in my own app. Also, the sample code and /example code have different imports HOT 12
- Error: GestureDetector must be used as a descendant of GestureHandlerRootView HOT 1
- Swiping Transition HOT 2
- Remove unnecessary checks HOT 4
- Replace 2 loops by one HOT 1
- Example shared element transition HOT 2
- ^0.3.8 - Interactions not working into a modal component HOT 2
- ^0.3.8 Wrong positions when more than 1 image HOT 10
- Question: can I get access to current scale without use events?
- how to retrain actual image quality on zoom image
- Not working HOT 2
- Infinite list? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-awesome-gallery.