Comments (21)
👍 had the same thought myself
from bootstrap-accessibility-plugin.
Thanks for asking. This is coming once we get the community play with the plugin and give us suggestions on improvements and refinements. We already received good feedback and are happy we didn’t rush with pull requests. HTH!
On Jan 30, 2014, at 3:17 PM, Justin Stockton [email protected] wrote:
had the same thought myself
—
Reply to this email directly or view it on GitHub.
from bootstrap-accessibility-plugin.
👍 to @patrickhlauke request. Accessibility should be not an option but standard.
Great work, though! It's about time somebody takes care on that issue
from bootstrap-accessibility-plugin.
Thanks. Point taken. :)
On Jan 31, 2014, at 2:02 AM, Stefan Baumgartner [email protected] wrote:
to @patrickhlauke request. Accessibility should be not an option but standard.
Great work, though! It's about time somebody takes care on that issue
—
Reply to this email directly or view it on GitHub.
from bootstrap-accessibility-plugin.
👍 for merging into core Bootstrap. I'm glad this project exists, though, so I'll be using it/providing feedback as is. Thanks!
from bootstrap-accessibility-plugin.
Looking through some of the styles, @mdo would not merge in some changes. Changing the .alert color contrast to simply use black would be immediately rejected. twbs 3.1 alert contrast currently meets WCAG 2.0 Level AA, but that took several tries before someone found a color combination the core team liked enough to merge in.
Here's the last change: twbs/bootstrap#11432 You can follow the references from there.
from bootstrap-accessibility-plugin.
The large chunk of changes have to do with keyboard and ARIA support. I am sure we can reconcile the visual style differences.
On Feb 7, 2014, at 9:35 AM, Zac Echola [email protected] wrote:
Looking through some of the styles, @mdo would not merge in some changes. Changing the .alert color contrast to simply use black would be immediately rejected. twbs 3.1 alert contrast currently meets WCAG 2.0 Level AA, but that took several tries before someone found a color combination the core team liked enough to merge in.
Here's the last change: twbs/bootstrap#11432 You can follow the references from there.
—
Reply to this email directly or view it on GitHub.
from bootstrap-accessibility-plugin.
We've always been on board with improving the accessibility features of Bootstrap. The biggest problem has been coordination and scope of changes. I have yet to dive into this more extensively, but we obviously welcome any and all practical improvements that can be made.
<3
from bootstrap-accessibility-plugin.
Seems like a good chunk of this requires only simple changes to the static HTML in Bootstrap's docs (rather than invasive JS magic):
Selector | Add attribute |
---|---|
[data-toggle=dropdown] |
aria-haspopup="true" |
.modal-content |
role="document" |
[data-toggle="collapse"] |
role="tab" |
[data-slide="prev"] [data-slide="next"] |
role="button" |
.nav-tabs |
role="tablist" |
.nav-tabs > li |
role="presentation" |
.nav-tabs > [data-toggle="tab"] .nav-tabs > [data-toggle="pill"] |
role="tab" |
from bootstrap-accessibility-plugin.
+1 for Merging.
from bootstrap-accessibility-plugin.
@cvrebert These roles are only needed when JS is running, therefore they should be added with the JS. For example, if they were added in the HTML, and a screen-reader user doesn't have access to JS, he/she will be very confused because the functionality described is missing.
from bootstrap-accessibility-plugin.
@weboverhauls Bootstrap already pretty much assumes (at least for the widgets in question) that JS is running.
from bootstrap-accessibility-plugin.
@weboverhauls I think that train already left the station a long time ago...devs adding roles directly to their HTML, and not generating it via JS, is a fairly common practice. I'd say any screenreader user without JS running is going to have a surprising/bad time nowadays on most sites.
from bootstrap-accessibility-plugin.
Sorry to hear that Patrick (and Chris). I thought you had a much higher appreciation for inclusive design and progress enhancement. Code quality is key. Please move this discussion to Twitter if you'd like.
from bootstrap-accessibility-plugin.
I'm just stating the facts about how Bootstrap is currently architected, not any opinion on the merits of that architecture.
Please move this discussion to Twitter if you'd like.
No thanks. Intelligent discussions don't fit into 140 characters.
from bootstrap-accessibility-plugin.
I think it should be noted that WebAIM has studied the usage of JavaScript in screen readers and found the overwhelming majority have JavaScript enabled. Granted, this is a survey without a control group, so a big grain of salt. Similar results have been found in previous surveys, though.
from bootstrap-accessibility-plugin.
The screen reader example was just an obvious use case. The much bigger issue was outlined in a recent study in UK which showed that .9% of ALL users had JS enabled but didn't receive it. http://bit.ly/RTzBVk
from bootstrap-accessibility-plugin.
Code from the plugin continues to be ported into core, so closing issue.
from bootstrap-accessibility-plugin.
Is the plugin's code going to be slimmed down accordingly, as things get ported into core?
from bootstrap-accessibility-plugin.
The plugin is smart to overwrite the core features if we feel our implementation is better. In other words, we have been able to avoid conflicts so far.
On Oct 3, 2014, at 2:33 PM, Chris Rebert [email protected] wrote:
Is the plugin's code going to be slimmed down accordingly, as things get ported into core?
—
Reply to this email directly or view it on GitHub.
from bootstrap-accessibility-plugin.
I would like to see the plugin slimmed down.
from bootstrap-accessibility-plugin.
Related Issues (20)
- AMD/CommonJS support
- Inappropriate role attributes in dropdowns HOT 1
- Should include jQueryUI license text
- Focus outline when tabbing through navbar HOT 1
- Relationship with bootstrap
- VoiceOver on iPad not work to access modal body HOT 2
- Bootstrap 4 HOT 5
- iframe within modal content not accessible via keyboard
- Uncaught TypeError: Cannot read property 'Constructor' of undefined
- Outdated package on npm HOT 1
- Test
- Modal isn't going back to where it was -BS 3.3.7, 1.0.5 accessibility HOT 4
- Modal not able to tab to new elements due to enforcefocus function HOT 3
- 1.0.5 release? HOT 4
- Collapse is inaccessible by keyboard if all panels are closed by default HOT 2
- Security vulnerability: reliance on EOL jQuery version
- Getting "bootstrap-accessibility.js:637 Uncaught TypeError: Cannot read property 'Constructor' of undefined" some conflict with carousel component. Custom build w/o carousel? HOT 1
- Potential security issue
- Tabindex on accordions HOT 1
- no tooltips HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bootstrap-accessibility-plugin.