Comments (5)
Hi @setaman , this kind f error message isn't something that should be returned in any circumstances, so it's a bug indeed.
I'm not sure about how this package is handling multipart requests and would require investing some time on it.
from openapi-validator-middleware.
Hi @kobik, It is getting even worse. I just found out that the validation of the multipart/form-data
body fails, if i set image
to be required. The root of all evil is the _validateBody method.
My first issue, where TypeError: validator.validate is not a function
is thrown, is caused by:
...
// is undefined, no body --> no Content-Type header
const contentType = this._getContentType(requestOptions.headers);
...
// the validator is there, but we cannot reach it because of the undefined 'contentType'
// the validator is in methodSchema.body.multipart/form-data
const validator = methodSchema.body[contentType] || methodSchema.body;
I put the validation right after multer in the chain. Multer assigns the image to req.file
, so the validation of the body do not pass:
const validator = methodSchema.body[contentType] || methodSchema.body;
// body has no image field
// methodSchema.body.multipart/form-data has no image to
if (!validator.validate(body)) {
return validator.errors || [];
}
I really want this library to work correctly and would like to help. But there are inconsistencies in the validation strategies in general. We see that in the described cases the headers are not checked, which in turn leads to the fact that Body cannot be validated. The question is whether you, the creators and maintainers, want to see the validation of the presence of the headers and the body and the correctness of the headers according to the specification as part of the functionality of this library.
from openapi-validator-middleware.
Hi @setaman, indeed we'd like this package to be as consistent and validate correctly according to the specification.
You're more than welcome to submit a PR.
from openapi-validator-middleware.
@kobik I will try to find some time between my work and studies to look at the issues
from openapi-validator-middleware.
Thanks @setaman, much appreciated.
from openapi-validator-middleware.
Related Issues (20)
- Unknown query parameters handling
- How to Validate multiple versions HOT 2
- Internationalization HOT 3
- simple parent child spec fails HOT 3
- Invalid Server URL error HOT 1
- Regression? Express + OpenAPI 3.0 + Multer + multipart/form-data rejects valid file HOT 1
- Update lockfile to automatically remove the vulnerability introduced by validator HOT 1
- what is require('../../src/middleware') meant to reference? HOT 4
- Parameter Serialization support
- contentTypeValidation boolean not supported for Open API 3.0
- Validate Response - Express HOT 1
- OpenAPI v3.1 Support HOT 3
- Path trailing parameter not validated as required HOT 2
- Are there any plans to add support of response validation? HOT 1
- Not validating if there is required header or query param HOT 2
- Circular references not supported ?
- Fastify integration fails when using fastify-multipart
- the field validation works with openApi 3.0.0? HOT 2
- Is it maintained?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from openapi-validator-middleware.