Giter Site home page Giter Site logo

Comments (9)

pbek avatar pbek commented on July 18, 2024 1

I still need to look into that, but since every line could have a different font face and size (unlike in kate) and doesn't need to be in monotype, like the line numbers, changing something there might not make a lot of sense all the time...

from qownnotes.

pbek avatar pbek commented on July 18, 2024 1

24.5.1

  • In the note editor, the line-number font size will now grow with the editor font size

from qownnotes.

pbek avatar pbek commented on July 18, 2024 1

I guess that could be hacked somewhere into https://github.com/pbek/qmarkdowntextedit/blob/353cfb063dc5fe21294d852638b08f25820b66b1/qmarkdowntextedit.cpp#L1705-L1842, pull requests welcome.

from qownnotes.

pbek avatar pbek commented on July 18, 2024

Phew, good question. But the line height could be in a different font which then still would get cut...
But I wouldn't consider that a bug. 🤔

from qownnotes.

o-l-a-v avatar o-l-a-v commented on July 18, 2024

It's a visual glitch, as in does not look to be intended, thus I submit-ed it as a bug.

Font should resize to whatever line space is available so it does not get cut?

from qownnotes.

pbek avatar pbek commented on July 18, 2024

Font should resize to whatever line space is available so it does not get cut?

That's not something that can be done easily (if at all) in a QWidget application.

from qownnotes.

o-l-a-v avatar o-l-a-v commented on July 18, 2024

That's not something that can be done easily (if at all) in a QWidget application.

Setting font size in line counter given a zoom level on change of zoom is not easy either? Match font size in the editor? KDE Kate does that (I know it's using Qt, don't know if it uses QWidget. 🙂).

from qownnotes.

pbek avatar pbek commented on July 18, 2024

There now is a new release, could you please test it and report if it works for you?

from qownnotes.

o-l-a-v avatar o-l-a-v commented on July 18, 2024

Yeah, was waiting for the Windows release to be built. Looks much better, the characters scale and are not clipped anymore, thanks. 🙂

For lines where content scales to beyond 100%, what would be your thought about centering the line count centrally vertically? Screenshot of current behavior:

image

from qownnotes.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.