Giter Site home page Giter Site logo

Comments (3)

ZLLentz avatar ZLLentz commented on July 24, 2024

Oh this is annoying

Letting the ioc manager set the ioc name seems reasonable. I'm trying to figure out why this isn't an issue for other IOCs but I'm coming up blank. Usually this gets set to the directory name under iocBoot in ioc manager since this is how the ioc manager locates the st.cmd file. So we can possibly check the mismatch by comparing our iocname to the directory name? But this assumes things are being done the usual way (ioc path is /some/long/path/v1.0.0 and ioc name is set to the subdirectory name)

from ads-ioc.

klauer avatar klauer commented on July 24, 2024

I think there's no way we can do the check, unless we shell out to an external script. There's no real control flow options in st.cmd after all

I put this in the PR: 184e609
I think ideally we'd want a verification that they match, but in the meantime deferring to IOC Manager to set it if possible seems good enough to me?

from ads-ioc.

ZLLentz avatar ZLLentz commented on July 24, 2024

Yes, I think giving the IOC manager control makes the most sense.

from ads-ioc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.