NullPointerException in new version

[pchmn]

NullPointerException in new version

[pchmn]

Can you provide the code that provoque this bug ? I think that this is because the ChipView label is probably null.

[duke1712]

Actually I clicked on the list dropdown from the chipInput and when I clicked on that I got this error. Label cannot be null because if that was the case then the dropdown from chipInput shouldn't hv come right?

…

On Apr 20, 2017 11:10 PM, "pchmn" ***@***.***> wrote: Can you provide the code that provoque this bug ? I think that this is because the ChipView label is probably null. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASXAx7hT32ifEib7IOdYFJuLbOi6HxzOks5rx5htgaJpZM4NDVmi> .

[pchmn]

You're right. I fixed the bug and pushed it in v1.0.3.
Telle me if it works.

[duke1712]

Yes it's fixed but now the letter icon is not coming when creating chips programmatically. The place where the letter icon should come is blank.

[pchmn]

I can't reproduce the bug. You're sure the label is not null when trying to create the letter icon ?

[duke1712]

Yes the label is not null, because if the label would have been null then the text inside the chip shouldn't come right?

[duke1712]

I am attaching the screenshot it may help you.
I am adding this chip programatically using
chip.addChip()

[duke1712]

I noticed that when adding chips using java, there is a NonNull Annotation in avatarIcon. My icon uri is null but I need the letter icon. So the error might be in the function addChip which is not accepting null avatarUri

[pchmn]

Yeah ok I will investigate this. Maybe I would be able to fix this only tomorrow, I'm sorry.

Thanks for your return and I'll tell you when this will be fixed

[duke1712]

Ya no problem, I am also experimenting on your sample project and if I get something il post it here.

[duke1712]

Modify these lines in your sample project which will help you recreate the bug.

ChipExampleActivity.java

 @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_chip_examples);
        // butter knife
        ButterKnife.bind(this);
        LinearLayout linearLayout=(LinearLayout)findViewById(R.id.abc);

        ChipView chip=new ChipView(this);
        chip.setLabel("Pritesh");
        chip.setPadding(2,2,2,2);
        chip.setHasAvatarIcon(true);
        linearLayout.addView(chip);

        // chip 1
        mChip1.setOnChipClicked(view -> {
            Toast.makeText(ChipExamplesActivity.this, mChip1.getLabel() + ": clicked", Toast.LENGTH_SHORT).show();
        });

activity_chip_Example.xml

`

<LinearLayout
    android:orientation="vertical"
    android:layout_width="match_parent"
    android:layout_height="wrap_content"
    android:padding="16dp">

    <!-- first line -->
    <LinearLayout
        android:id="@+id/abc"
        android:layout_width="match_parent"
        android:layout_height="match_parent"
        android:orientation="horizontal">

    </LinearLayout>

    <LinearLayout
        android:orientation="horizontal"
        android:layout_width="match_parent"
        android:layout_height="wrap_content">

        <com.pchmn.materialchips.ChipView
            android:id="@+id/chip2"
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            android:layout_marginRight="16dp"
            app:label="Chip 1"
            app:hasAvatarIcon="false"
            app:deletable="false"/>

`

Just compare whith your code and make the changes to see the bug.

[pchmn]

So I tested as you taught me, but it works, I don't have your bug. A screenshot :

[duke1712]

did you add it throgh java file or xml? Xml is working perfect there ks a problem when adding chips from java file

…

On Apr 21, 2017 8:02 PM, "pchmn" ***@***.***> wrote: So I tested as you taught me, but it works, I don't have your bug. A screenshot : [image: image] <https://cloud.githubusercontent.com/assets/12658241/25282180/0317661a-26b0-11e7-8ff0-85e2f950130c.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASXAx54hffXBcdAmH1Y6GPYv6EVeIddsks5ryL3cgaJpZM4NDVmi> .

[pchmn]

I added the chip with java :

        ChipView chipView1 = new ChipView(this);
        chipView1.setLabel("Pritesh");
        chipView1.setPadding(2,2,2,2);
        chipView1 .setHasAvatarIcon(true);

        mLayout.addView(chipView1);

[duke1712]

Ok I am trying once.

…

On Apr 21, 2017 8:29 PM, "pchmn" ***@***.***> wrote: I added the chip with java : ChipView chipView1 = new ChipView(this); chipView1.setLabel("Pritesh"); chipView1.setPadding(2,2,2,2); chipView1 .setHasAvatarIcon(true); mLayout.addView(chipView1); — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ASXAx9Pj9SfiIxd8mgtWl8wHyKMoo1ZQks5ryMQ_gaJpZM4NDVmi> .

[pchmn]

The problem is still there ?

[duke1712]

The problem was still there. I am trying to debug the code and find the problem and notifying you soon.

[duke1712]

Okay bro thanx the latest version has solved. Thanks alot