Bad conditionalization for lispworks with-hash-table-locked

[pcostanza]

Bad conditionalization for lispworks with-hash-table-locked

[pcostanza]

As far as I can tell, there is no LispWorks 8, so I cannot test whether closer-mop will actually work on LispWorks 8. I prefer to conditionalize only for implementations where closer-mop actually works.

[Yehouda]

That means we (LispWorks Ltd) cannot run our automatic tests on it or any Quicklisp system that uses it and uses eql-specializer (because that is where it breaks).

[pcostanza]

Ok, that's indeed a serious issue. I will fix this ASAP, as you suggested in your original report. Thanks a lot for brining this up.

[Yehouda]

Thanks.

[pcostanza]

I have just committed the fix to this repository. It should normally become part of the next Quicklisp update (but that's not under my control).

Thanks again for reporting this issue.

[quicklisp]

This change breaks closer-mop on all non-LispWorks lisps.

[Yehouda]

Yes, it should really be #+(and lispworks (not (or lispworks4 lispworks5))) Even simpler is to remove the import and to conditionalize just the place it is used in closer-lispworks.lisp (#+lispworks5.1 sys:with-hash-table-locked #-lispworks5.1 hcl:with-hash-table-locked

[pcostanza]

Zach: Thanks a lot for paying attention. Indeed this was a mistake. I now fixed it, same as Yehouda's first suggestion for the import clause. I hope this is fine now and I haven't overlooked anything else.