The example panics on UnexpectedEof, is this expected?

[pdeljanov]

The example panics on UnexpectedEof, is this expected?

[pdeljanov]

There is no dedicated "no more packets" error since for some supported formats there is no practical distinction between an EOF condition and when we've read all the packets. For example: MP3, there is no actual defined duration and therefore nothing to check if we reached the end other than just failing to read more data from the file/source.

So this is expected behaviour. The descriptive text for the UnexpectedEof should read "end of stream". If there is an actual problem with your files you will get some kind of DecodeError with a detailed message as to what the issue is.

[VillSnow]

@pdeljanov

umm, interesting.. I haven't known that mp3 might not have any sentinel or total record size.

However, this kind of EOF occurs everytime files are decoded and have to distinguished from other IO errors.
Probably this is the most strict check. Very complicated and still not clear if this is perfect.

let packet = match format.next_packet() {
    Ok(packet_ok) => packet_ok,
    Err(Error::IoError(ref packet_err))
        if packet_err.kind() == std::io::ErrorKind::UnexpectedEof =>
    {
        println!("complete!");
        break;
    }
    Err(packet_err) => panic!("{:?}", packet_err),
};

I prefer like this. I know adding enum item is incompatible change and not easy to do that. So it's just a suggestion.

let packet = match format.next_packet() {
    Ok(packet_ok) => packet_ok,
    Err(Error::EndOfStream)
    {
        println!("complete!");
        break;
    }
    Err(packet_err) => panic!("{:?}", packet_err),
};