Lack of auto-indent

[pencilcode]

Lack of auto-indent

[davidbau]

This is an error message that comes from to the underlying coffeescript compiler that's used in the ace coffeescript mode.

[davidbau]

Can you be more specific?

If I type something like this, it does auto-indent on the next line:

fn = (x) ->

On Tue, Mar 11, 2014 at 1:25 AM, Weihang Fan [email protected]:

Is it intended?

Reply to this email directly or view it on GitHubhttps://github.com//issues/43
.

[weihang7]

It does not indent for statements such as if and for, which is (I think) caused by editor.setBehavioursEnabled(false) in line 1249 in editor_view.js.

[davidbau]

Does that really do autoindenting in CoffeeScript? If I remember correctly, I found the BehaviorsEnabled flag really annoying for HTML documents where the autoindenting was too aggressive. Can you test it on a branch and see how it behaves?

[weihang7]

It turns out that the code in ACE responsible identifying lines for autoindenting is line 53 in https://github.com/ajaxorg/ace/blob/master/lib/ace/mode/coffee.js. However, I can't understand this blob of regex enough to fix it.

[davidbau]

Here is the regexp disassembled, perlre /x style:

/(?:
  [({[=:]      # Opening parentheses or brackets
 |[-=]>        # OR single or double arrow
 |\b(?:        # OR one of these words:
   else        #    else
  |switch      # OR switch
  |try         # OR try
  |catch       # OR catch, optionally followed by:
    (?:\s*[$A-Za-z_\x7f-\uffff][$\w\x7f-\uffff]*)?  # a variable
  |finally     # OR finally
 ))\s*$/       # all as the last thing on a line (allowing trailing space)

Here is a possible modification:

/(?:
  [({[=:]      # Opening parentheses or brackets
 |[-=]>        # OR single or double arrow
 |\b(?:        # OR one of these words:
   else        #    else
  |switch      # OR switch
  |try         # OR try
  |catch       # OR catch, optionally followed by:
    (?:\s*[$A-Za-z_\x7f-\uffff][$\w\x7f-\uffff]*)?  # a variable
  |finally     # OR finally
 ))\s*$        # all as the last thing on a line (allowing trailing space)
|              # ---- OR ---- some new stuff:
^\s*           # a line starting with optional space
(else\b\s*)?   # followed by an optional "else"
(?:            # followed by one of the following:
   if          #    if
  |for         # OR for
  |while       # OR while
  |loop        # OR loop
)\b            #    (as a word)
(?!.*\bthen\b) # ... but NOT followed by "then" on the line
/

In other words (without spaces or comments):

/(?:[({[=:]|[-=]>|\b(?:else|switch|try|catch(?:\s*[$A-Za-z_\x7f-\uffff][$\w\x7f-\uffff]*)?|finally))\s*$|^\s*(else\b\s*)?(?:if|for|while|loop)\b(?!.*\bthen\b)/

If you test this (or something like it) and it works, you should try to push it to ace upstream, and we can patch it to our fork of ace.

[davidbau]

Frank - can I also ask you to patch it in to this repo? It's the specific fork of ace we're using for Pencil Code.

https://github.com/PencilCode/pencilcode-ace

[weihang7]

Seems fixed.