Giter Site home page Giter Site logo

Comments (6)

penge avatar penge commented on July 29, 2024 6

@olfek and @anshulxyz

What do you think about this new icon?

Icon

light



Toolbar

light

dark



Options

block-site-options



The idea is to have icon that would look also good in Dark Mode or Incognito Mode, as pointed out by @olfek. Because the new icon would no longer be a simple black bold B, it is also shown in Options page, to make a clear connection between the toolbar icon and Options page.

Note: To make it a bit easier to visit the Options, a simple left mouse click on the icon will work now. Before: Right click on the icon, then click on Options from the menu. This option will still be there as it's standard behavior.

from block-site.

olfek avatar olfek commented on July 29, 2024 1

its perfect @penge

from block-site.

anshulxyz avatar anshulxyz commented on July 29, 2024 1

@penge looks great, good visibility

from block-site.

penge avatar penge commented on July 29, 2024

Very subtle indeed. The only way is to either change icon color so it's ok in both normal and incognito, or give the icon a white background but that would make it look worse in normal mode 💁

Looked up https://developer.chrome.com/docs/extensions/reference/extension/#property-inIncognitoContext with https://developer.chrome.com/docs/extensions/reference/action/#method-setIcon but it's not a method that would work here (as there's no way to set icon from background script before the extension is started in incognito).

from block-site.

anshulxyz avatar anshulxyz commented on July 29, 2024

How about an icon, where the "B" has a small white border. This way it will work in all the cases.

from block-site.

penge avatar penge commented on July 29, 2024

@olfek Great! I'll be adding it to the next version then. Shoud be out in about 2 days.

from block-site.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.