Comments (3)
RFC: In the 5.12 "package name version BLOCK" syntax, PPI currently can parse the version component as a float:
ppidump 'package foo 1.11;'
PPI::Document
PPI::Statement::Package
[ 1, 1, 1 ] PPI::Token::Word 'package'
[ 1, 9, 9 ] PPI::Token::Word 'foo'
[ 1, 13, 13 ] PPI::Token::Number::Float '1.11'
[ 1, 17, 17 ] PPI::Token::Structure ';'
though perl does recognize it:
perl -WE 'package foo 1.11 { print $VERSION }'
1.11
Should PPI force anything that can be a version to be a PPI::Token::Number::Version?
from ppi.
Statements like use 5.020
don't have their versions parsed as Versions. Going with the flow would seem to be to leave Float version numbers as Floats.
from ppi.
Merged into master with some refactoring.
from ppi.
Related Issues (20)
- provide delimiters for PPI::Token::QuoteLike::{Words,Regexp,Command}, PPI::Token::Quote::{Literal,Interpolate}
- dies with unicode bare key name HOT 1
- use signatures not supported by PPI HOT 1
- Lexical subroutine doesn't return correct name HOT 2
- Misparse bareword as label HOT 7
- Maybe bump minimum Perl version to 5.008?
- try/catch syntax misparsed
- Extending PPI HOT 2
- Parse DSL as a sub HOT 2
- The Keyword Question HOT 20
- Verify behaviour of BEGIN, UNITCHECK, CHECK, INIT and END
- TODO: tidy everything
- TODO: remove superfluous `#pod` lines
- TODO: verify INHERITANCE documentation for all classes
- TODO: auto-generate copyright, author, contributor notices (see strictures.pm)
- TODO: probably un-inline Inlined $self->__add_element(shift);
- TODO: create test cases for the constructs in Syntax::Construct
- Heredocs are stripped from stringified Document object HOT 1
- QuoteLike::Words->literal returns wrong results after contents change
- have the dependents test test all dependents
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ppi.