Misparse of &&= and ||=

[perl-critic]

Misparse of &&= and ||=

[moregan]

Would you please double-check that those results are from PPI 1.216_01? The results you report are 1.215 behavior that was fixed in 1.216_01 (see #18). With 1.216_01 I get:

ppidump '$foo ||= 0;'
                    PPI::Document
                      PPI::Statement
[    1,   1,   1 ]     PPI::Token::Symbol       '$foo'
[    1,   6,   6 ]     PPI::Token::Operator     '||='
[    1,  10,  10 ]     PPI::Token::Number       '0'
[    1,  11,  11 ]     PPI::Token::Structure    ';'

Thanks.

[moregan]

The change in parsing of ||= et al. is why I believe ValuesAndExpressions::RequireConstantVersion no longer passes its tests.

More notes I've accumulated on the same general topic:

Subroutines::RequireArgUnpacking has started reporting on:

sub BUILD {
    my ($class, $options_ref) = @_;
    $options_ref ||= @_;
}

ErrorHandling::RequireCheckingReturnValueOfEval has started warning on:

return ($has_module_cache{"$mod$version"} ||= eval("require $mod; Exporter::require_version('$mod', $version) if ($version); 1"));

ValuesAndExpressions::ProhibitMixedBooleanOperators has stopped reporting:

$LineEnding ||= guess_endings($File) or
    $this->{_ErrorMsg} = "message $FileName.", goto done;

[thaljef]

Would you please double-check that those results are from PPI 1.216_01?

You were right. I stand corrected.

The change in parsing of ||= et al. is why I believe ValuesAndExpressions::RequireConstantVersion no longer passes its tests.

That's exactly what led me here. Upon further inspection, it appears that we had written a workaround for the problem. And now that the problem is fixed in 1.216_01, I need to remove it.

I will look into those other cases. Thanks for letting me know.

[moregan]

There's also a workaround in ProhibitAugmentedAssignmentInDeclaration. I've been waiting for years to get rid of it, but you're welcome to go ahead without me :-)

[thaljef]

I've been waiting for years to get rid of it, but you're welcome to go ahead without me :-)

Done.