active language tab should match language displayed

[balmas]

active language tab should match language displayed

[annakrohn]

@balmas, if this looks good to you I'll do the pull request and merge.

[balmas]

@annakrohn I might be misreading this, but it looks to me like this would set both tabs to active if both translations are present. is this the desired behavior?

[annakrohn]

It should break out of the assignment once it hits the first translation that has text, but my js isn't fantastic so I could be wrong.

[balmas]

ah, I missed that return statement there. Generally, I think I try to avoid returns out of loop statements. I think I would probably do something like:

var available_langs = [];
$('#lang_tabs a').each(function() {
    if ($('#' + this.getAttribute('aria-controls')+ ' p')[0].innerHTML.length > 0) {
        available_langs.push(this);
});
if (available_langs.length > 0) {
    available_langs[0].addClass("active").tab('show');
}

It's not as concise, but it makes the intent of the code easier to understand.

[annakrohn]

Changed in commit 31a40f5.

The array was being funny though, changes to objects in it didn't seem to effect the DOM, so I instead saved an attribute to use when setting the active tab.

[balmas]

ok thanks! this is fine to merge.