Separators need conversion as well

[persian-tools]

Separators need conversion as well

[ali-master]

Hi Saeed Jan,

@psparsa created a PR and He refactored all digits functions and he can implement this feature. Or if you want, help us by creating a PR because the Persian-Tools is yours.

[psparsa]

BTW Why didn't we use the toLocaleString function instead of replace?

the toLocaleString is one of the Number object methods, we can only use that for converting English numbers to Farsi, Arabic & etc; and the second problem, that's possible our input be a string that contains the English digits, and we wanna change those digits to Farsi.. at this case the Number.toLocaleString is not practical.

e.g:

input:
10,000 ﷼

output:
۱۰,۰۰۰ ﷼

[saeedalipoor]

Hi @ali-master,
I would be happy to open a PR as soon as possible.

Thanks, @psparsa
What do you think of changing the replace function to something like this:

str.replace(/\d+/g, match=>Number(match).toLocaleString('fa-ir'))

[psparsa]

What do you think of changing the replace function to something like this:

str.replace(/\d+/g, match=>Number(match).toLocaleString('fa-ir'))

seems correct and will works; but just for converting english digits to ....
in my last PR i refactored the digits converters... now it's like this:

EnToFa:
String(value).replace(enDigitsRegex, (char) => `${faNums[Number(char)]}`);

[saeedalipoor]

Yes, I proposed that for converting English digits to Farsi or other locales digits.
It replaces numbers instead of replacing digits one by one.

[ali-master]

@saeedalipoor Jan, any news or updates on this issue?