Giter Site home page Giter Site logo

Comments (4)

dweindl avatar dweindl commented on August 18, 2024 1

When I import this model with my Petab problem using pyPESTO PEtab importer and compile to AMICI, it defines L_0 as a StateId of the AMICI model

Hi, that is correct / intended. In AMICI, parameters are constant (unlike in SBML). Any target of an event assignment, assignment rule, or rate rule will be a state variable in the AMICI model.

from petab.

leodarrigade avatar leodarrigade commented on August 18, 2024 1

@dweindl Thanks for the precision.

@dilpath Thank you, it is working fine with your solution. I think it could be useful to include in the PEtab documentation that parameters in the condition table cannot change values over time and be subject of event.

from petab.

dilpath avatar dilpath commented on August 18, 2024

Hi,
I would suggest rewriting your PEtab problem to remove L_0 from the condition table, which should only include values/variables that are constant throughout time.

Instead, rename L_0 to L_0_conc in your condition table, and add an initialAssignmentRule in your SBML model that sets L_0(t=0) = L_0_conc. You will need to add an SBML parameter for L_0_conc. Let me know if the issue persists.

from petab.

dilpath avatar dilpath commented on August 18, 2024

Great!

Agreed, currently there is ambiguity in the current version of the spec, and behavior could be tool-specific. The spec will be updated to specify how to handle "time-dependent" parameters, in the next version of PEtab. The issue is tracked at #513

from petab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.