Giter Site home page Giter Site logo

Comments (28)

mrtree1 avatar mrtree1 commented on June 11, 2024

Never used PhoneGap Build, but I wonder if there is a namespace clash as the plugin uses org.apache.cordova unofficially as many others do. I was wondering if the plugin should change to something unique. Have you tried editing the plugin.xml and changing the plugin id there to something not called org.apache.... If that doesn't work then we'll need to know more about the error. Also let us know if that is the problem as it'll motivate a change in namespace quite soon.

from cordova-plugin-ibeacon.

niroam avatar niroam commented on June 11, 2024

I did try changing the plugin id but i left the first bit, since you said the same thing i tried a completly different name (see my fork) and that did work!! thanks heaps!

from cordova-plugin-ibeacon.

mrtree1 avatar mrtree1 commented on June 11, 2024

Thanks for confirming @niroam I think this does mean we should change the id for the plugin. @petermetz what do you think?

from cordova-plugin-ibeacon.

petermetz avatar petermetz commented on June 11, 2024

@mrtree1 @niroam

Thanks guys, lots of helpful info really appreciate it!

If I understand it correctly, the plugin will either become an official Cordova plugin, or we have to change it's ID in order to avoid problems on PhoneGap Build.

I'll type out an email to the Cordova mailing list, see if there's any chance making it official, if not we can fall back to changing the ID which I'd like to avoid if possible, since it's kind of a breaking change, even if the codebase stays intact.

Cheers,
Peter

from cordova-plugin-ibeacon.

mrtree1 avatar mrtree1 commented on June 11, 2024

Thanks @petermetz For what it's worth I'll readd the advertising API in this week, so the basic features will be complete again.

from cordova-plugin-ibeacon.

niroam avatar niroam commented on June 11, 2024

thanks heaps guys, please note i changed the ID to com.conetix.ibeacon under my fork and submitted to phonegap to test it, if you end up submitting it your self hopefully this won't cause any issues let me know!

from cordova-plugin-ibeacon.

alexcroox avatar alexcroox commented on June 11, 2024

Let us know the outcome of this, I'd prefer to use this in Build

from cordova-plugin-ibeacon.

petermetz avatar petermetz commented on June 11, 2024

We had a short conversation in the mailing list and the decision is to go with the plugin renaming. The guys were advising against it and also the plugin as is most probably would not get accepted anyway.

The upside is that with a different ID I'll be able to submit it to Phonegap Build and the migration process shouldn't be that painful as I first thought.

from cordova-plugin-ibeacon.

Barranha avatar Barranha commented on June 11, 2024

Hi... first sorry for my poor english.
I need to send notifications to my users triggered by an ibeacon.
I'm devolipng an app for android and ios. Is this plugin ready for use? Is it for android and ios?
Could I do some tests?

Regards,
Fernando

from cordova-plugin-ibeacon.

Barranha avatar Barranha commented on June 11, 2024

By the way I'm using phonegap build

from cordova-plugin-ibeacon.

petermetz avatar petermetz commented on June 11, 2024

Hi @Barranha

Yes, the plugin is ready for use.

It supports both iOS and Android, some features may be exclusive to one of those platforms but the fundamental stuff is all there for both of them.

You can do testing if you have ibeacon hardware (or hardware that is capable of simulating it, such as a macbook).

We are working on the Phonegap Build submission, in the meantime you can use the temporary version of @niroam I guess.

Peter

from cordova-plugin-ibeacon.

niroam avatar niroam commented on June 11, 2024

my submission is at https://build.phonegap.com/plugins/936 if anyone wants to check status and use it if they decide to accept it while @petermetz and team are working on an official submission!

from cordova-plugin-ibeacon.

Barranha avatar Barranha commented on June 11, 2024

Thank you
Em 30/07/2014 19:31, "niroam" [email protected] escreveu:

my submission is at https://build.phonegap.com/plugins/936 if anyone
wants to check status and use it if they decide to accept it while
@petermetz https://github.com/petermetz and team are working on an
official submission!


Reply to this email directly or view it on GitHub
#24 (comment)
.

from cordova-plugin-ibeacon.

mrtree1 avatar mrtree1 commented on June 11, 2024

@petermetz After my weekend commits, I'm wondering if we should park the 2.0 branch, and change the namespace to com.petermetz.cordova.ibeacon on a 3.0 branch which we then push out as master and submit to the plugin registry. What do you think?

from cordova-plugin-ibeacon.

wonderdogone avatar wonderdogone commented on June 11, 2024

So anyone getting this to work using the phongapbuild plug? I am not seeing and response. NO errors or anything. I assume since these are ibeacons the example code variables uuid refers to the proximity uuid?

from cordova-plugin-ibeacon.

petermetz avatar petermetz commented on June 11, 2024

@mrtree1 I'll go through all the namespace/package definitions in the DOM and the Objective-C code tomorrow. If you could do the same on Android, we could push it to master in no time.

from cordova-plugin-ibeacon.

petermetz avatar petermetz commented on June 11, 2024

@wonderdogone I have never used Phonegap Build and without any errors it is hard to tell what could go wrong. If @niroam is still around, he might be able to help but if not, all I can say to you is to wait until we submit the official, renamed package into Phonegap Build.

from cordova-plugin-ibeacon.

niroam avatar niroam commented on June 11, 2024

I can try to help, i haven't gotten around to testing the phonegap plugin i submitted yet but it should work fine. @wonderdogone you need to provide more details, are you using a basic phonegap app created by the cmd line and pasting the sample code from @petermetz doco ? can you upload your code to github somewhere ? I'm new to phonegap plugins so this might be a question for the other guys but since i renamed the plugin id, will the reference to cordova.plugins.locationManager.*** continue to work from the sample code or does it need to match the plugin id now ?

from cordova-plugin-ibeacon.

mrtree1 avatar mrtree1 commented on June 11, 2024

@petermetz I'm a bit piled up with other work today and tomorrow, but can tackle it on Friday afternoon. If you create a new branch and add your changes there I'll do the rest on Friday or Saturday.

from cordova-plugin-ibeacon.

wonderdogone avatar wonderdogone commented on June 11, 2024

ok thanks. For just seeing if I was getting feedback form the plug I just made this simple index.html which i was hoping to hit a button to start the scan and see some results in the console. Here is that page
https://gist.github.com/wonderdogone/bed4b3701317165d1741

my config file is

https://gist.github.com/wonderdogone/3e3f7dab0f12bab638d3

The strange part is that it's not logging anything to console using phonegapbuild remote debugging. But i think this is because of another issue which is that it's not the cordova locationManager?

from cordova-plugin-ibeacon.

mrtree1 avatar mrtree1 commented on June 11, 2024

@wonderdogone You are trying to run plugin code before Cordova/PhoneGap is ready. The document ready event is fired when the page is loaded, but to use any plugin code you have to wait until Cordova has loaded all the scripts for each of your requested plugins which is the deviceready event.

You need to have some code like this:

document.addEventListener('deviceready', function() {
    //now you can call plugin code
}, false);

To see output from console.log you need to add the Cordova console plugin.

from cordova-plugin-ibeacon.

wonderdogone avatar wonderdogone commented on June 11, 2024

duh on me. ok going to try that now. thanks

from cordova-plugin-ibeacon.

mrtree1 avatar mrtree1 commented on June 11, 2024

I'm just looking at the PhoneGap submission process, I've submitted the version with namespace changes on the v3.x branch (to avoid impersonating org.apache), and we'll see if they accept it. It says it can take up to a week. If it's accepted, then this is the line to add in the phonegap config.xml file:

<gap:plugin name="com.unarin.cordova.beacon" version="3.0.0" />

Will let you know when we have something accepted

from cordova-plugin-ibeacon.

FrigoEU avatar FrigoEU commented on June 11, 2024

Any news on this? I've tried niroam's submitted branch of this plugin on PB Build but this doesn't work. Among others, the references to underscorejs are still on the org.apache.cordova.ibeacon namespace, so the very first require() immediately fails.

from cordova-plugin-ibeacon.

mrtree1 avatar mrtree1 commented on June 11, 2024

Still says 'Pending Review' on the PhoneGap dashboard. I will post when I get any change. It's been over a week so far so imagine it can't take much longer.

from cordova-plugin-ibeacon.

mrtree1 avatar mrtree1 commented on June 11, 2024

I was sure I'd posted this last week but the PhoneGap plugin is now available. Just add this to your config and hopefully it will work on PhoneGap. Please let us know if it works!

  <gap:plugin name="com.unarin.cordova.beacon" version="3.0.0" />

from cordova-plugin-ibeacon.

wonderdogone avatar wonderdogone commented on June 11, 2024

I tried this plug with phonegapbuild today and when ranging I am receiving "didRangeBeaconsinRegion" and I am noticing that the "rssi" key is changing as I move around the beacon so I guess this means it's working. Great job on this.
I will continue to test it more tomorrow.

from cordova-plugin-ibeacon.

mrtree1 avatar mrtree1 commented on June 11, 2024

@wonderdogone Thank you for confirming the plugin is working as expected. I'll close this issue now, but open a new issue if you hit any issues

from cordova-plugin-ibeacon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.