New functions

[petertillema]

New functions

[Ti64CLi]

You didn't add the RIGHT( function?

[PeterTillema]

ICE/src/functions.c

Lines 660 to 707 in 9a0a180

	// RIGHT(
	else if (function2 == tRIGHT) {
	bool shouldParseArguments = true;
	bool shouldCallRoutine = true;
	if (outputPrevType == TYPE_NUMBER) {
	if (outputPrevPrevType == TYPE_VARIABLE) {
	LD_HL_IND_IX_OFF(outputPrevPrevOperand);
	shouldParseArguments = false;
	if (outputPrevOperand & 0xFF) {
	LD_A(outputPrevOperand);
	} else {
	shouldCallRoutine = false;
	}
	} else if (outputPrevPrevType == TYPE_CHAIN_ANS) {
	if (!outputPrevOperand) {
	shouldParseArguments = false;
	shouldCallRoutine = false;
	expr.outputReturnRegister = expr.outputRegister;
	}
	} else {
	return E_SYNTAX;
	}
	}
	if (shouldParseArguments) {
	if ((res = parseFunction2Args(index, REGISTER_A, true)) != VALID) {
	return res;
	}
	}
	if (shouldCallRoutine) {
	OR_A_A();
	ProgramPtrToOffsetStack();
	if (!ice.usedAlreadyMean) {
	ice.programDataPtr -= SIZEOF_MEAN_DATA;
	ice.MeanAddr = (uintptr_t)ice.programDataPtr;
	memcpy(ice.programDataPtr, (uint8_t*)MeanData, SIZEOF_MEAN_DATA);
	ice.usedAlreadyMean = true;
	}
	CALL_NZ(ice.MeanAddr + 3);
	ResetHL();
	ResetBC();
	ResetA();
	}
	}

[Ti64CLi]

Then, why did you overlined the RIGHT( for rightshift ?

[PeterTillema]

Because it's implemented now, don't need to add it anymore :P

[Ti64CLi]

Oh, ok, sorry for that. So, I guess LEFT is also implemented?

[Ti64CLi]

It's so weird.
I saw that LEFT wasn't implemented yet
// LEFT( if (function2 == tLEFT) { }
But he works on my calc ^^'

[PeterTillema]

Sure it works, but it doesn't produce any code yet.

[Ti64CLi]

Though, when I compile that code :
Disp LEFT(4,1)
It displays 8

[PeterTillema]

Yes, because both arguments are numbers, and then it gets optimized:

ICE/src/parse.c

Lines 666 to 667 in a547470

	} else if (function2 == tLEFT) {
	temp = outputPrevPrevOperand << outputPrevOperand;

[Ti64CLi]

Ok, thank you

[Xenoxis]

Wait, Stop, DelVar, Menu( can be implemented ?
And if yes, will they be ?

[Xenoxis]

Will also be good if you can add switch statement with case

[PeterTillema]

Wait is essentially the same as Pause, Stop is a good one, DelVar is the same as 0->,Menu( is way too hard to implement, and switch / case looks too much like C.

[Xenoxis]

Is it bad if it looks like C ? Because switch can be interesting for some variables processing as interger and would be more efficient than lots of if, isen't it ?

[Ti64CLi]

I agree with Xenoxis, Menu( could be very useful ;)

[LAX18]

I would argue against it, as it would be used on the main screen, not in the canvas mode. I, personally, do not see many ICE programs not use the drawing canvas, as ICE's main attraction is the use of the canvas to expand upon BASIC programs.

[PeterTillema]

Sure, Menu( is very useful, but it would be very large code, and you can 'easily' write it yourself.