Giter Site home page Giter Site logo

PEP-8 & refactoring about pexpect HOT 4 CLOSED

pexpect avatar pexpect commented on September 26, 2024
PEP-8 & refactoring

from pexpect.

Comments (4)

stephenfin avatar stephenfin commented on September 26, 2024

Some ideas

  • fix pep-8 errors reported by pylint
  • convert examples in docstrings to doctest compatible examples
  • modularize __init__.py
  • convert some functions with >5 args to use **kwargs and parse this
  • remove commented out code (it's in version control)
  • resolve todos or open issues if not possible

from pexpect.

takluyver avatar takluyver commented on September 26, 2024

Hi Stephen,

I don't like doing big pep 8 cleanups - I try to roughly follow pep 8 when
I'm writing or changing code, but reformatting other code doesn't seem
worth it, especially as it introduces conflicts with other changes.

I also don't have a problem with functions with more than five arguments.
Using kwargs makes our code longer, and makes introspection less useful, do
it seems like a step backwards.

Other than that, I think your ideas mostly make sense. Hold off on
splitting up init, though: I want to do that carefully as we add
support for asyncio and windows.

from pexpect.

stephenfin avatar stephenfin commented on September 26, 2024

Sounds good. I'll have a look at the other items in that case and see what I can do.

from pexpect.

takluyver avatar takluyver commented on September 26, 2024

Thanks!

from pexpect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.