Giter Site home page Giter Site logo

Comments (3)

jackiew1 avatar jackiew1 commented on June 9, 2024

@pgaskin, I've committed the change. You can close whenever you want.

from kobopatch-patches.

pgaskin avatar pgaskin commented on June 9, 2024

Thanks! Note that for single-commit fixes like this, you can include closes #113 or fixes #113 somewhere in the commit message (I usually put it like (fixes #113) at the end of the title, or fixes #113 after a blank link at the end of the body.

I'll do a release with this change either a month from now or when the next update gets released.

from kobopatch-patches.

jackiew1 avatar jackiew1 commented on June 9, 2024

Thanks! Note that for single-commit fixes like this, you can include closes #113 or fixes #113 somewhere in the commit message (I usually put it like (fixes #113) at the end of the title, or fixes #113 after a blank link at the end of the body.

I've always thought you preferred to close issues yourself. That's why I didn't. Is that not the case?

I'll do a release with this change either a month from now or when the next update gets released.

Unless you know something I don't, there's no need to do a new release before the next fw update. Only one person reported the problem and they've already implemented the updated patch. If I see someone else raising the same issue I'll direct them to the MR thread where I posted the new patch code.

Apparently the Polish problem has already been reported to Kobo so they may apply their own fix for next time. In which case I may need to rejig the patch again anyway.

from kobopatch-patches.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.