Comments (3)
@pgaskin, I've committed the change. You can close whenever you want.
from kobopatch-patches.
Thanks! Note that for single-commit fixes like this, you can include closes #113
or fixes #113
somewhere in the commit message (I usually put it like (fixes #113)
at the end of the title, or fixes #113
after a blank link at the end of the body.
I'll do a release with this change either a month from now or when the next update gets released.
from kobopatch-patches.
Thanks! Note that for single-commit fixes like this, you can include
closes #113
orfixes #113
somewhere in the commit message (I usually put it like(fixes #113)
at the end of the title, orfixes #113
after a blank link at the end of the body.
I've always thought you preferred to close issues yourself. That's why I didn't. Is that not the case?
I'll do a release with this change either a month from now or when the next update gets released.
Unless you know something I don't, there's no need to do a new release before the next fw update. Only one person reported the problem and they've already implemented the updated patch. If I see someone else raising the same issue I'll direct them to the MR thread where I posted the new patch code.
Apparently the Polish problem has already been reported to Kobo so they may apply their own fix for next time. In which case I may need to rejig the patch again anyway.
from kobopatch-patches.
Related Issues (20)
- Patches for 4.33.19759 HOT 5
- "Un-Force user text-align in div,p tags in KePubs" break alignment changes HOT 1
- 3 Patch updates needed in librmsdk.so.1.0.0.yaml HOT 2
- Missing patch for enabling stylus on kepubs HOT 3
- Patches for 4.34.20097 HOT 11
- Patches for 4.35.20400 HOT 10
- Default kepub fonts HOT 7
- Reading stats question HOT 1
- Missing Clara2E comment labels HOT 1
- Patches for 4.36.21095 HOT 14
- Musl library compatibility? HOT 3
- Patches for 4.37.21533 HOT 8
- Migrate CI to GitHub Actions
- Patches for 4.37.21582 HOT 7
- Patches for 4.37.21586 HOT 4
- "Block WiFi firmware upgrade" not working
- Patches for fw 4.38.21908 HOT 4
- Patches for 4.38.21908 HOT 9
- Patches for 4.39.22801 HOT 46
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kobopatch-patches.