Giter Site home page Giter Site logo

Comments (2)

ens-lgil avatar ens-lgil commented on September 27, 2024

Dear @ramiromagno,

When we implemented the "Display category", at the beginning this was only meant to be used in the pie charts, to provide a summarised information about the ancestry distribution for each Score.
We also updated the "ancestry_broad" data so now they all match the NHGRI-EBI GWAS ancestry categories.

Then when we did some users testing, it appeared that there was an interest to have these distributions available in the metadata exports and, by extend, in the REST API. However we didn't intend to provide a detailed mapping of the distribution with the "Ancestry categories".

Regarding the rest/score endpoints, we choose to use a 2/3 letters notation to reduce the size of the rest call (mainly for the rest/score/all endpoint) and keep the endpoints as fast as we could (we store the distribution in the database in a similar structure, therefore this is relatively quick to build and return the REST API call).

The /rest/ancestry_categories endpoint is mainly there to provide the labels corresponding to the 2/3 letters ancestry notations.
However, thanks to your suggestions, we are thinking about improving the /rest/ancestry_categories endpoint by providing the "Ancestry categories" associated with the "Display categories", e.g.:

"AFR": {
	"display_category": "African", 
	"categories": [
		"African American or Afro-Caribbean", 
		"African unspecified",
		"Sub-Saharan African"
	]
},
"EUR": {
	"display_category": "European",
	"categories": [
		"European"
	]
},
...

Best regards,
Laurent

from pgs_catalog.

ramiromagno avatar ramiromagno commented on September 27, 2024

Thank you @ens-lgil for the update.

from pgs_catalog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.