Comments (8)
Indeed, it is more clear. +1 to your proposal for README and output message.
Changed in 2b8d950.
Thanks for your feedback ;-)
I'll work on the tests and prepare a new release asap then :-)
from check_pgbackrest.
Hi,
Thanks for asking :-)
Have you tried the dev version yet?
I'm currently working on improving the multi-repo support. I'm looking how to operate on all repo defined dynamically. But it has some major code impacts mostly for the archives service.
I'm aiming to get a new release ready by the end of this month, with or without that improvement.
Kind regards
from check_pgbackrest.
I've just pushed the initial rework of that implementation.
You already can try the dev version of this PR :-)
I'll look at adding extra tests for this feature next week.
from check_pgbackrest.
Hi,
Hi!
Thanks for asking :-)
Have you tried the dev version yet?
Yes, I tried dev version and one from #24.
I like the idea to not make --repo
mandatory. This avoid forgetting to add a new check service when we add a new repository for backup.
I just wonder if the perdata are meaningful as the counter aggregates all repositories. Maybe we should have separate counters:
Before:
full=5 diff=12 incr=0 latest=diff,20210906-170207F_20210913-060002D latest_age=27631s latest_full=20210912-050002F latest_full_age=113017s
After:
repo1-full=1 repo1-diff=6 repo1-incr=0 repo1-latest=diff,20210906-170207F_20210913-060002D repo1-latest_age=27631s repo1-latest_full=20210912-050002F repo1-latest_full_age=113017s
repo2-full=4 repo2-diff=6 repo2-incr=0 repo2-latest=diff,20210912-050002F_20210913-050001D repo2-latest_age=27631s repo2-latest_full=20210912-050002F repo2-latest_full_age=113017s
I also tried archive service and I think we should separate counters or make --repo
mandatory. Actual counters are wrong:
check_pgbackrest-dev -S archive -s archives --repo 2
WAL_ARCHIVES OK - 2512 WAL archived, latest archived since 7h35m44s | latest_archive_age=27344s num_archives=2512
check_pgbackrest-dev -S archive -s archives --repo 1
WAL_ARCHIVES OK - 8009 WAL archived, latest archived since 7h37m17s | latest_archive_age=27437s num_archives=8009
# Without repo option
check_pgbackrest-dev -S archive -s archives
WAL_ARCHIVES OK - 8009 WAL archived, latest archived since 7h40m6s | latest_archive_age=27606s num_archives=8009
I'm currently working on improving the multi-repo support. I'm looking how to operate on all repo defined dynamically. But it has some major code impacts mostly for the archives service.
I'm aiming to get a new release ready by the end of this month, with or without that improvement.
Thanks!
from check_pgbackrest.
I just wonder if the perdata are meaningful as the counter aggregates all repositories.
I believe there's a purpose to keep the counters aggregated. If you want to know how many backups your have inside all your repos and which one is the latest. If you want to enforce a retention check on a specific repo, you'll need the --repo
option.
So it's not really for cases where a user would "forget" to add the extra service but more about checking the consistency accros the repos.
I also tried archive service and I think we should separate counters or make
--repo
mandatory. Actual counters are wrong:check_pgbackrest-dev -S archive -s archives --repo 2 WAL_ARCHIVES OK - 2512 WAL archived, latest archived since 7h35m44s | latest_archive_age=27344s num_archives=2512 check_pgbackrest-dev -S archive -s archives --repo 1 WAL_ARCHIVES OK - 8009 WAL archived, latest archived since 7h37m17s | latest_archive_age=27437s num_archives=8009 # Without repo option check_pgbackrest-dev -S archive -s archives WAL_ARCHIVES OK - 8009 WAL archived, latest archived since 7h40m6s | latest_archive_age=27606s num_archives=8009
Actually, I don't believe the counter is wrong. It's the number of "unique" wal archives you have accros your repos.
--repo
allow to check the repo content for each repo, but without the repo option, it allows to check the consistency accross all of them.
Imagine you miss 1 wal archive in repo1 but it is actually present in repo2. You'd have to check that manually and ack the alert. Where here, since you have the archive, archive-get
will find it and allow the recovery.
I strongly believe having the "per repo" and the "accros repos" checks are complimentary, not exclusives. However, I agree the readme or at least the output messages could be improved to reflect that behavior.
Perhaps "8009 WAL archived" -> "8009 unique WAL archived", and num_archives
-> num_unique_archives
?
from check_pgbackrest.
Indeed, it is more clear. +1 to your proposal for README and output message.
from check_pgbackrest.
Hi,
2.1 has just been released ;-)
from check_pgbackrest.
Thanks! I will try.
from check_pgbackrest.
Related Issues (20)
- Warning issued if pgbackrest.conf contains repo1-retention-archive-type=diff HOT 5
- --service=archives list missing archives but it's not true HOT 15
- Support other compression types than gz HOT 2
- service=retention should check presence of backups HOT 4
- Service archive Azure Storage account support HOT 2
- Memory leak? HOT 10
- invalid perfdata warnings (by ElasticsearchWriter and GraphiteWriter) HOT 9
- archives service will not work if the WAL files are not compressed HOT 2
- Option for check of minimum age of oldest full backup HOT 3
- Min WAL not found after stanza upgrade HOT 3
- Feature: zabbix integration HOT 3
- Failed to decode json when there's a WARNING for the pgbackrest HOT 6
- Problems after a few switchovers "found a boundary" HOT 5
- Version pgbackrest compatible avec check_pgbackrest 2.3 HOT 2
- Perl warning errors when running the check_pgbackrest command HOT 2
- Archive checking very slow or fails to check at all HOT 6
- Bug with RPM packaging from PGDG HOT 3
- Bug with --repo-s3 HOT 7
- Malformed JSON HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from check_pgbackrest.