Add support for joining two rows

[phase1geo]

Add support for joining two rows

[jaslar]

What's the command to split a row?

[phase1geo]

Control Return when editing text. Place the cursor where to split.

[jaslar]

Shift-Ctrl-Return to Join?

…

On Mon, Jun 22, 2020 at 2:10 PM Trevor Williams ***@***.***> wrote: Control Return when editing text. Place the cursor where to split. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMDL7NCYZOJ26SOYJSLCSILRX63DHANCNFSM4MBTKMQQ> .

-- James LaRue Mobile: [phone] Website and Blog: jlarue.com Twitter: @jaslar

[phase1geo]

What does joining two rows mean?

Keep in mind that each row not only contains text, but also notes, checkboxes, tags, labels, etc. Joining rows is a tricky endeavor from that standpoint vs. simple copy/paste.

[jaslar]

All good questions. I suppose the default would be to adopt the properties of the node you are merging TO (the parent or Previous sibling) or FROM (to a child or Next sibling). I'd suggest the former: Esc, shift-backspace. Erase the division between this and its predecessor. You're right that cut and paste works. I seem to have to fiddle with children more. Maybe that's just me. Don't mean to grumble. Big leaps in this app lately!

…

On Thu, Jun 25, 2020, 1:51 PM Trevor Williams ***@***.***> wrote: What does joining two rows mean? Keep in mind that each row not only contains text, but also notes, checkboxes, tags, labels, etc. Joining rows is a tricky endeavor from that standpoint vs. simple copy/paste. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMDL7NAZHQFX3D4ZU3FDMQLRYOTDHANCNFSM4MBTKMQQ> .

[phase1geo]

@jaslar Okay, another scenario to get your feedback on (and I may have more in the future). Consider the following example:

• Parent one
  • Child A
• Parent two
  • Child B

If "Parent two" is selected and chosen to be joined, does it join with "Child A" or "Parent one"? If it is joinable with either, what happens to "Child B"?

[phase1geo]

Additionally, are there any outlining applications that implement this functionality that I could use as a reference (just to see what choices they make in different scenarios)?

[phase1geo]

In the case where I am joining two sibling nodes, here is what the before and after would look like (in my opinion):

BEFORE:

• Sibling A
• Sibling B
  • Child X
  • Child Y

AFTER

• Siblingb A Sibling B
  • Child X
  • Child Y

I'm assuming that this would be the expected result. Do you agree?

[phase1geo]

I was just noticing that the current split functionality does the following:

BEFORE

• Text More text
  • Child A
  • Child B

AFTER (split between "Text" and "More")

• Text
  • Child A
  • Child B
• More text

Should this case instead result in:

• Text
• More text
  • Child A
  • Child B

[phase1geo]

Interesting. I just tried the above row split scenario with OmniOutliner and got the following result:

• Text
  • More text
  • Child A
  • Child B

Does this seem like the behavior that you would expect? I guess that it would make sense if joining the first two rows resulted back in:

• Text More text
  • Child A
  • Child B

[phase1geo]

I apologize for all of the posts here, but I noticed a preference setting in OmniOutliner that allows the application to switch the behavior of hitting the Enter key after creating a new row. If one option is chosen (the default), hitting Return will indent the new row if the current row already has children. When this option is set, hitting "Control + Return" to split the row will cause it to look like:

• Text
  • More text
  • Child A
  • Child B

However, if the other option is chosen, hitting Return after editing a row will add a new sibling row after the current row's children such that the result of using "Control + Return" results in:

• Text
  • Child A
  • Child B
• More text

Interesting. Unfortunately, I don't see any ability to join lines in OmniOutliner so I don't know how it would handle this operation.

[jaslar]

Thanks for thinking this one through. I think the intuitively correct split is this: - Text - More text - Child A - Child B That is, the split maintains the current hierarchy for the split line. MERGING seems like it should also be at the same level, so yes, BEFORE: - Sibling A - Sibling B - Child X - Child Y AFTER - Sibling A Sibling B - Child X - Child Y The other case seems trickier: - Parent one - Child A - Parent two - Child B If I join at Parent two, I think it becomes: * Parent one * Child A Parent two * Child B That is, you're merging to the previous line, and the children maintain the same relationship they had before, in this case, indented by one. If I wanted Child B unindented, I'd perform that separately.

…

On Thu, Sep 17, 2020 at 10:35 PM Trevor Williams ***@***.***> wrote: I apologize for all of the posts here, but I noticed a preference setting in OmniOutliner that allows the application to switch the behavior of hitting the Enter key after creating a new row. If one option is chosen (the default), hitting Return will indent the new row if the current row already has children. When this option is set, hitting "Control + Return" to split the row will cause it to look like: - Text - More text - Child A - Child B However, if the other option is chosen, hitting Return after editing a row will add a new sibling row after the current row's children such that the result of using "Control + Return" results in: - Text - Child A - Child B - More text Interesting. Unfortunately, I don't see any ability to join lines in OmniOutliner so I don't know how it would handle this operation. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMDL7NHESGMPD6D57Z2UYQLSGLPQRANCNFSM4MBTKMQQ> .

-- James LaRue Mobile: [phone] Website and Blog: jlarue.com Twitter: @jaslar

[phase1geo]

Makes sense to me. I'll work on that implementation. As for the split, I will change it to look like what you suggest as the default. I may put in a preference option that will allow the user to change this behavior back to the current implementation.

Thanks for the feedback. I appreciate it!

[phase1geo]

I have implemented the join functionality which is in the devel branch and will be generally available in the next stable release. I have also reworked the split functionality such that the new node becomes the parent of the original node's children as is shown above.