Giter Site home page Giter Site logo

Comments (4)

webcultist avatar webcultist commented on August 26, 2024

Would it be possible to have this optional in this theme? I still see many advantages over using PostCSS as for example the very good editor implementations and as libSASS is very fast, I don't see the need to completely remove SASS. What do you think or what are the reasons you see the need to completely change all the SASS structures & workflows to postCSS?

from p2-theme-core.

EvanLovely avatar EvanLovely commented on August 26, 2024

I always like the idea of using tools that let us use syntax that will one day be standard. So for example, we've got native CSS variables coming our way so let's start using them so we can get used to them as developers now. Additionally, this let's us use progressive enhancement; I'm sure that we can get it set up so that if a browser supports CSS vars natively it can use them and if not it uses the statically compiled values. This can let us do some really cool stuff.

I see your bigger point though and that's letting people choose sub-sets of functionality to build up their own "theme core" - it's something I've wanted and thought about for a while now but still need to have a firm vision before it's possible to implement. I could see someone choosing a theme core and being asked if you wanted Sass or PostCSS. Again, there'd be a good chunk of work to break apart this repo into modular parts to allow that though. Let me think about it.

Also, since we need PostCSS to use Autoprefixer in the current state of the repo, it's possible that this could be a simple config option. Though then that means you'd need all the dependencies for both approaches installed, which makes it more bloated. The other thing I want to do in v10 is make this all smaller, so that goes against this.

from p2-theme-core.

archnode avatar archnode commented on August 26, 2024

One thing I implemented while working on something quite similar is something that could be used as an equivalent for scss2json for PostCSS. Maybe it's of use in this context: https://github.com/archnode/postcss-extract-variable-scheme. I use this by extracting files based on variable prefixes and process and move this files to their destination inside my patternlab structure.

from p2-theme-core.

illepic avatar illepic commented on August 26, 2024

Closing this as the p2-theme-core is going into feature freeze and v10 has been killed.

from p2-theme-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.