Ensure Content-Transfer-Encoding binary as the default for MDN's

[phax]

Ensure Content-Transfer-Encoding binary as the default for MDN's

[phax]

Thanks for the very detailed analysis. Let me try to sum it up:
you want a possibility to customize the Content-Transfer-Encoding of MDNs and let binary be the default.
Is this correct?

[open-gdsn]

Thanks for the very detailed analysis.

You are welcome. I help out a lot on Stackoverflow and need to put my foot where my mouth is when stating to people there that 'debugging' with opensource is not that hard (and I'm fairly into protocols so that helps too)

you want a possibility to customize the Content-Transfer-Encoding of MDNs and let binary be the default.

Not specifically. If the current behaviour of AS2-Lib is good according to the specs (cannot find it myself, already checked), I'm fine with that. Just need a reference to the spec then (or the Drummond interoperability tests, since they sometimes (often?) deviate from the spec if all agree) just to 'convince' others current behaviour is officially good. But since the default is, for outgoing messages, already 'binary' (explicitly leaving the CTE out would be fine too!!!) and can be configured on the partnership, I'd say that having the same on outgoing MDN's would not be wrong.

[phax]

I cross-checked my code and found, that I already have the possibility to define a "sending Content-Transfer-Encoding" and a "receiving Content-Transfer-Encoding".
Currently that is only used for "Messages" but not for MDNs.
Is it okay to use these settings for MDNs as well, or do we need separate configuration options?

[kukel]

Re-using these is fine, I already noticed them. But having a global one would be great as well.

Or a feature to NOT have them set by javax.mail if not set by the application.

[phax]

I was investigating and "NOT have them set" in javax.mail is not an option. I found neither a system property nor a really reliable way to disable this. So setting the default CTE should do the trick.

[phax]

Theoretically it should now be impossible to have no CTE set, because the default (binary) should always be set, except if overwritten in the partnership (using the content_transfer_encoding partnership attribute).
Please confirm that this works for you.
@zharpaz I would like to get this released as 4.1.1 before I merge your PR.

[kukel]

Confirmed that this change makes signed MDN's work with our 'old' software. Now let's see how I can try to enable async MND's in the 'as2-peppol-server'

[kukel]

Remarkable, you only set the CTE on the outer headers and the inner body parts are still 7bit. I (thought I) tried this too and did not get it to work, hence setting them on the inner bodyparts. Weird but it works

[phax]

AS2MDNReceiverModule should do the trick :) Port 10081!

[kukel]

async MDN outgoing ;-), traffic the other way around is the next step. Where do you 'discuss' things btw? Cannot imagine you use github for this?

[phax]

I have a Slack for discussion, but it's not used too heavily... will send you and invite.
Most of the things are resolved in the issues - and the rest is just working ;-)

Outgoing async MDN: AS2ClientSettings.setAsyncMDNUrl (String)

[phax]

@kukel as I couldn't find your email address, I sent you an invitation on LinkedIn...

[phax]

This is fixed for 4.1.1 - new issues as new issues pls. Feel free to reference this one. Thx