Calculating MIC for signed message when *not* having MDN options fails

[phax]

Calculating MIC for signed message when *not* having MDN options fails

[kukel]

This is what I ended up with:

final ECryptoAlgorithmSign eSigningAlgorithm = ECryptoAlgorithmSign.getFromIDOrNull(aPartnership.getSigningAlgorithm());

if (eSigningAlgorithm == null)
    throw new OpenAS2Exception ("The signing algorithm '" + aPartnership.getSigningAlgorithm() + "' is not supported!");
final String sMIC = AS2Helper.getCryptoHelper ().calculateMIC (aMsg.getData (),eSigningAlgorithm,

And the following piece of code is superfluous then in the calculateMic method:

final String sDispositionOptions = aPartnership.getAS2MDNOptions ();
final DispositionOptions aDispositionOptions = DispositionOptions.createFromString (sDispositionOptions);

if (LOGGER.isDebugEnabled ())
  LOGGER.debug ("DispositionOptions=" + aDispositionOptions);

Will setup my github correctly so I can create PR's

[phax]

Thx. Makes sense. Btw which algo is it?
Sorry, misread it

[kukel]

I do not completely understand your question in this context. One of the reasons we are looking for newer software is that ours does not support modern algorithms and sha-1 is the max.

(Sorry, closed by accident)

[phax]

Well, this is a tricky one. There are the Disposition-Notification-Options and there is the partnership signing algorithm.

What you are outlining suits my understanding:

• AS2SenderModule must use the partnership signing algorithm
• MDN creation must use the Disposition-Notification-Options

[kukel]

Yes this is what I think it should be... But in the MDN creation it still works, unrelated pieces of code. So the fix I proposed is safe (afaics)

[phax]

I changed it slightly, so that a default algorithm is used (depending on the algorithm suite used), if none, or an invalid one is provided.

[phax]

SNAPSHOT 12 and onwards contain this fix. Thanks again for pointing it out.

[kukel]

Providing a default if none is provided sounds ok, but I am not a fan of defaults if invalid ones are provided. It's masking wrong configurations.

[phax]

That's why I added an extra logging, so that it gets obvious

[kukel]

Thankls, that makes it better (although logging tends to be 'neglected' way too often is our experience if there is additional (error) logging that should be ignored)