Giter Site home page Giter Site logo

You cannot *not* request an MDN about as2-lib HOT 7 CLOSED

phax avatar phax commented on July 29, 2024
You cannot *not* request an MDN

from as2-lib.

Comments (7)

kukel avatar kukel commented on July 29, 2024 1

I don't think it is an enhancement but the result of the fix in #42 (9070fc2) which is effectively not fully correct and hence a 'bug' ;-)

from as2-lib.

kukel avatar kukel commented on July 29, 2024

There is a

@Nonnull
  public AS2ClientSettings setSenderData (@Nonnull final String sAS2ID,
                                          @Nonnull final String sEmailAddress,
                                          @Nonnull final String sKeyAlias)
  {

on the AS2ClientSettings, should the email address from that not be used instead of a fixed string in 71d92f3#diff-71c23868cad98a869a3e7fcd1c7dcef8R174

from as2-lib.

phax avatar phax commented on July 29, 2024

You know my code better than me :)

from as2-lib.

phax avatar phax commented on July 29, 2024

Did you check whether it works as expected?

from as2-lib.

kukel avatar kukel commented on July 29, 2024

Will test later today.

from as2-lib.

kukel avatar kukel commented on July 29, 2024

Seems to be working!

from as2-lib.

phax avatar phax commented on July 29, 2024

Great - thanks for testing.

from as2-lib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.