Comments (6)
Hi Jochen!
I adopted the IPartnershipFactory and removed the getPartnerMap
and getPartnershipMap
methods as suggested - they are still available directly from within AbstractPartnershipFactory
.
Additionally I changed the return type of addPartnership
from void to EChange
to handle existing partnerships more gracefully.
Concerning the Mongo Partnership: I'd be happy to add this. I would create a separate Maven module (like as2-partnership-mongodb
) and add it to this workspace. Is there a standalone test available that works without having Mongo locally installed?
Thanks, Philip
from as2-lib.
Is there a standalone test available that works without having Mongo locally installed?
Not yet, but I wanted to write one anyway. I'm not too familiar with Maven and JUnit anymore, I usually do Gradle/Spock these days.
from as2-lib.
I adopted the IPartnershipFactory and removed the getPartnerMap and getPartnershipMap methods as suggested
Do you want to keep the other methods, like addPartner
, removePartner
and the others that don't have "ship" in their name? I think they are also unused.
from as2-lib.
They do make sense in certain ways. I extracted a sub-interface IPartnershipFactoryWithPartners
that should do the trick for you by sticking to the existing interface :)
from as2-lib.
Yes, it does the trick, thanks.
I must admit that I find it hard to understand the separation between Partner and Partnership. Why is Partnership
a real class whereas Partner is only a Map? It seems to me as if Partners are helper objects that are only used to bootstrap the Partnerships from an XML configuration.
I think that an application using as2-lib should be supposed to care about either Partners or Partnerships. If it should care about Partners, then the creation of the actual Partnerships should be encapsulated somewhere within the lib.
I'm not sure if that makes any sense to you, if it doesn't, maybe that proves, that the current parter vs. partnership concept is a little hard to grasp. ;-)
from as2-lib.
Well good point. I introduced a class Partner
with a corresponding IPartner
interface. Class Partner
is basically a StringMap
but with a different type around. This should make things more easily graspable.
But you are absolutely right that this construct is only used within XML. For the rest, the getSenderID
and getReceiverID
stuff is sufficient. Therefore I moved everything that is "xml partnership" related to a separate sub-package.
from as2-lib.
Related Issues (20)
- Performance issues in AS2 servlet when transferring files HOT 2
- unable to send file to AS2 server from AS2-LIB HOT 5
- getting started HOT 9
- Can AS2DirectoryPollingModule run with as2-lib-spring-demo HOT 7
- Disposition isn't correct when using servlet HOT 14
- "Invalid HTTP Request" Error with Servlet-based Demo-Web-App HOT 8
- java.lang.IllegalStateException: unable to create shared stream: java.io.FileNotFoundException: /tmp/as2-lib-res-16551011638687829143.tmp (No such file or directory) HOT 7
- Spring boot: possible to make custom handler a spring managed bean? HOT 3
- partnership attribute: remove_cms_algorithm_protection_attrib HOT 2
- Error receiving from chunked transfer encoding HOT 11
- MIC calculation on outgoing AS2 is incorrect when using compress before signing HOT 9
- Question : Does AS2 includes standard HTTP headers and custom generated headers for communication between 2 systems interacting using AS2 protocol. HOT 1
- Cant' send files to distant client using "MainSendToMendelsonTestServer.java" HOT 2
- Trying to use RSASSA_PKCS1_V1_5_WITH_SHA3_256 signing alg results in IllegalArgumentException: Unknown signature type requested: RSASSAPSS HOT 13
- latest certificates from keystore is not fetching when service is running HOT 2
- Advice on creating documentation HOT 7
- Can't work with AS2 version 5.0 with bc-fips HOT 4
- NoClassDefFoundError: javax/mail/internet/MimeBodyPart HOT 2
- Private Key is Null for public key HOT 4
- bcMail temporary files not deleted when compression is used (as2-lib 5.1.2)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from as2-lib.