Parser doesn't remove slashes before quotes

[pherrymason]

Parser doesn't remove slashes before quotes

[pherrymason]

It's been a long time so I should check it again more in deep.
A quick check in the code suggests that the parser indeed is not unescaping \, but I don't remember the reason behind that.
Let me check it more deeply

[ondrejcech]

Sorry for the late reply @raulferras . I've prepared PR #96 that will solve the issue. I've checked the proposed behavior with xgettext tool and it produces the same output.

[ondrejcech]

Thanks for your response. Do you have any updates? I've checked Symfony implementation on PoFileLoader and they're removing the escape character (using stripcslashes) - https://github.com/symfony/symfony/blob/6d10f8891ecdf480e4dccacc394b29b9dc85528a/src/Symfony/Component/Translation/Loader/PoFileLoader.php#L127

The same behavior is used in poEdit desktop app.

I'll create pull request with proposed change but I'd like to know if there's any reason behind.

[pherrymason]

Sorry @ondrejcech , I haven't had time for it. Will try this week but I'm currently quite busy.
For the reason behind it, I can't really tell before playing with it as I said, I don't fully remember. What I remember is that I started this project from an existing code base so some decisions where just blind-copied.
It is weird that nobody complained about this all this years (not saying that current implementation is not wrong), but it could be that this part you mention is totally flawed. Maybe people has been using it around this.

If you are willing to open a PR I will check it for sure.